Changes on butterflies placement checks #3116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I made a commit to the master of my fork to resolve another issue and it ended up in this PR too. Now this PR can fix #3102 |
SmallJoker
reviewed
May 25, 2024
SmallJoker
approved these changes
May 29, 2024
|
I submitted another PR, #3125, which uses the engine's routine to handle butterfly and firefly placement and catching. Every possible interaction exception can be handled by having everything cared for by the engine. |
|
So can I close this (again)? |
This PR has been approved by core developers, so I would suggest letting them decide. |
|
I will close this PR. #3125 will be better thant that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2987 (by using
minetest.item_place)Fixes #3102 (by renaming the parameters)