New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move character.png to textures. #785

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@sofar
Member

sofar commented Jan 15, 2016

This file is obviously out of place, as the engine does not
load textures, ever, out of a models folder.

Move character.png to textures.
This file is obviously out of place, as the engine does not
load textures, ever, out of a models folder.
@Jordach

This comment has been minimized.

Contributor

Jordach commented Jan 15, 2016

Probably an issue since Taoki's implementation of models.

I'm reasonably sure that it loads from both - testing might be needed.

On 15 January 2016 at 05:29, Auke Kok notifications@github.com wrote:

This file is obviously out of place, as the engine does not

load textures, ever, out of a models folder.

You can view, comment on, or merge this pull request online at:

#785
Commit Summary

  • Move character.png to textures.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#785.

@ghost

This comment has been minimized.

ghost commented Jan 15, 2016

screenshot_20160115_100217
This is what appeared when I removed models/character.png outright.

@sofar

This comment has been minimized.

Member

sofar commented Jan 15, 2016

@everamzah but did you move it to ../textures/ ?

@ghost

This comment has been minimized.

ghost commented Jan 16, 2016

No, I deleted the file outright as a test. Normally, I move it to textures too, because of the console spam "Fail to load character.png" or whatever.

@sofar

This comment has been minimized.

Member

sofar commented Jan 16, 2016

3727  16:31:22.381774 open("/home/sofar/git/minetest/character.png", O_RDONLY) = -1 ENOENT (No such file or directory)

Irrlicht is somehow attempting to read from PWD. Irregardless, nothing is reading the texture from the models/ folder, so this commit should be merged.

@paramat

This comment has been minimized.

Member

paramat commented Jan 16, 2016

Terminal messages became more verbose recently which is why we are seeing it now.
Not sure moving is correct though, perhaps it is only looking in the texture pack for an optional override skin.

@sofar

This comment has been minimized.

Member

sofar commented Jan 16, 2016

@paramat The strace shows it never looks for this in models. So this should really go into textures.

the error comes from irrlicht looking in $PWD, which is unrelated, and I don't think this will fix that.

@paramat paramat added the Textures label Jan 16, 2016

@paramat

This comment has been minimized.

Member

paramat commented Jan 22, 2016

If it never looks in models how does it currently find it?

@MoNTE48

This comment has been minimized.

MoNTE48 commented Feb 19, 2016

Can a path be prescribed in the model?
In any case, +1. All the texture should be in one place.

@C1ffisme

This comment has been minimized.

C1ffisme commented Feb 19, 2016

I imagine, and I may be wrong since I haven't looked too closely at Minetest's code, that Minetest imports all resources (models, textures, sounds, schematics) from folders that are known to have said resources. It does not care if a sound is in the textures file, or if a model is in the schematics file. It simply loads it all in, though somewhere somebody probably put a log to tell people "Hey, I loaded this in!" without saying "from a file it shouldn't be in.".

That's just my hypothesis.

@paramat

This comment has been minimized.

Member

paramat commented Feb 21, 2016

👍 from me and sfan5 http://irc.minetest.ru/minetest-dev/2016-02-21#i_4540322 will merge soon.

@paramat

This comment has been minimized.

Member

paramat commented Feb 21, 2016

@paramat paramat closed this Feb 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment