Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control whether leaves decay after placed in-game. #846

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@theunifiedmind7
Copy link
Contributor

commented Feb 13, 2016

Hold shift while placing to preserve leaves, otherwise they'll decay like normal.
Original PR: #454

MT-Modder MT-Modder
Control whether leaves decay after placed in-game.
Hold shift while placing to preserve leaves, otherwise they'll decay like normal.
Original PR: #454
@paramat

This comment has been minimized.

Copy link
Member

commented Feb 14, 2016

👎 I prefer the original PR. It's more likely players will want to build hedges etc with undecaying leaves than to create tree schematics (which is often best done using lua tables anyway).
The original PR had 2 approvals already so if you change this to the original PR i'll merge.
As commented by kaeza:

if placer and placer:get_player_control().sneak ~= true then

should be

if placer and not placer:get_player_control().sneak then
@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2016

If you go back and read everyone says 👍 to decay by default. I see your point though.

Edit: I'm gonna wait for more responses.

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 14, 2016

Well it was equal votes for each, but amongst the devs nore approved it being undecaying by default and ShadowNinja was sort of okay with it either way, plus i would prefer undecaying by default.
However yes wait for more consideration.

@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2016

@paramat What do you think of adding a placer:is_player() check to this function?

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 14, 2016

I'm not sure.

@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2016

I'm a little hesitant because I'm not entirely sure if it's needed or if it would break certain mods. If a mod like pipeworks was to place leaves it would have to choose the default option and in this case they would decay. But I would assume if someone was setting up a system like that they would place a tree under or near the placer to prevent decay...so IDK either 😆

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 21, 2016

Ok apparently that check is not needed so go ahead without it.

@theunifiedmind7 theunifiedmind7 deleted the theunifiedmind7:leaf-decay-control branch Feb 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.