Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control whether to dig up #847

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@theunifiedmind7
Copy link
Contributor

commented Feb 13, 2016

This small change makes it so when the player is holding shift while digging cactus or papyrus it doesn't dig up. This is perfect for making windows in cactus buildings.

MT-Modder MT-Modder
Control whether to dig up
This small change makes it so when the player is holding shift while digging cactus or papyrus it doesn't dig up. This is perfect for making windows in cactus buildings.
@paramat

This comment has been minimized.

Copy link
Member

commented Feb 14, 2016

👎 If we need to put a hole in a cactus wall there are other ways to do this.

@PilzAdam

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2016

👎

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 16, 2016

Not sure. I'm not keen on having 'dig up' on cactus and papyrus, we don't have it for trees. Also it doesn't work on the large branched cacti.

@0-afflatus

This comment has been minimized.

Copy link

commented Feb 17, 2016

dig up is a bit unnecessary on papyrus and cacti. What would be ideal is a mod that allowed for felling trees properly. Like treecapitator but that works. Anyhow that's OT for this thread.

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 18, 2016

In fact, perhaps dig up should be removed from cacti because we now have branched cacti, this would solve this problem too, would you like to make that PR? I will +1 it.

@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2016

Should I just remove it all together? After removing it from cacti it would only have one use...papyrus. It seems silly to keep something with only one use, no?

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 18, 2016

I agree, but other devs might like to keep it for papyrus, for now while we wait for input just remove it from cactus. The function itself is public so should stay for mod use.

@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2016

Okay. I just realized that the cacti that are grown by the player don't have branches, so it's still useful for those. Do you think placed cacti should grow into branched cacti?

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 19, 2016

cacti that are grown by the player don't have branches, so it's still useful for those

Yes, i'm not sure what we should do then, best wait for more input.

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 21, 2016

Seeing how cacti are like any other cubic node, i can't see the point of dig up, it's not as if players need to harvest huge amounts of cactus. Papyrus perhaps is different because it's plantlike and has more uses. I personally think we can remove dig up from cactus.

@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2016

Okay just let me know what you and the other devs want and I'll do it.

@C1ffisme

This comment has been minimized.

Copy link

commented Feb 21, 2016

@paramat We could make cactus give players green dye, but that's not relevant right now.

@paramat

This comment has been minimized.

Copy link
Member

commented Feb 22, 2016

Okay, dig up used on a branched cacti will leave the branches hanging, this is a little embarassing, so i feel it should be removed.

@theunifiedmind7

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2016

Okay.

@theunifiedmind7 theunifiedmind7 deleted the theunifiedmind7:control-dig-up branch Feb 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.