Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steel sign + Update wooden sign texture #895

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@kilbith
Copy link
Contributor

commented Mar 6, 2016

As requested in #883

  • Crafting yields changed from 1 to 3.
  • Wooden sign texture updated to simpler and more wood-ish looking (texture by Gambit).

capture d ecran de 2016-03-06 11-45-26

capture d ecran de 2016-03-07 11-14-18

Cc: @PilzAdam @paramat

@PilzAdam

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2016

Using a loop here is ugly. Maybe create a local table generic_sign, register both nodes with it and use override_item to change the fields that differ between them?

@kaeza

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2016

👍 for the idea, but the code definitely needs work.

@kaeza

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2016

Sorry for posting multiple times. Was going to comment on individual lines, but would be better to do it here.

I agree with @PilzAdam. A better approach, IMHO, is to define a helper function register_sign taking only the differences (e.g. groups, description) as parameters and filling in the rest. Maybe even something similar to the (relatively) recent doors.register function.

@C1ffisme

This comment has been minimized.

Copy link

commented Mar 6, 2016

👍 I really like the new texture.

@paramat

This comment has been minimized.

Copy link
Member

commented Mar 6, 2016

I like the textures and support the addition of a steel sign.
I think the wooden one should have some darkened pixels in the same pattern as the steel one, to represent writing.

@paramat paramat added the Textures label Mar 6, 2016

@kilbith

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2016

@PilzAdam Updated.

I'll handle the wooden texture tomorrow.

@kilbith

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2016

@paramat Wooden texture updated. See 1st comment.

@paramat

This comment has been minimized.

Copy link
Member

commented Mar 7, 2016

👍

@paramat

This comment has been minimized.

Copy link
Member

commented Mar 7, 2016

@paramat paramat added this to the 0.4.14 milestone Mar 7, 2016

@paramat

This comment has been minimized.

Copy link
Member

commented Mar 9, 2016

@paramat paramat closed this Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.