Class-based Login, Logout and Callback views, plus successful_login overridable method #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #175.
These changes seem to make it fully
Django 2.1
compatible, and running the tests locally also show no issues withPython 3.7
. May be worth updatingtox
or the docs to reflect this if the tests are passing on your end.The only major change that might affect users is that
cas_ng_login
now has to be thename
of the login URL, in line with what is already in the documentation. Previously we were just callingreverse()
on the function itself. But since we have class-based views we can't do that anymore (as far as I'm aware).I'm also passing the entire
request
object tosuccessful_login
now instead of justuser
. I imagine this will give the most possible flexibility if people are passing in additional flags from theCAS server
or have some middleware or something.