Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Prevented crash when numVisibleItems is called with zero #15

Merged
merged 2 commits into from Oct 8, 2012

Conversation

Projects
None yet
3 participants
Contributor

tynril commented May 24, 2011

Added a safety check on the minimum amount of display items in ComboBox (1).

bit101 added a commit that referenced this pull request Oct 8, 2012

Merge pull request #15 from tynril/master
Prevented crash when numVisibleItems is called with zero

@bit101 bit101 merged commit e308f76 into minimalcomps:master Oct 8, 2012

Contributor

makc commented Oct 8, 2012

Seriously?

_numVisibleItems = Math.min(1, value); will prefer 0 in this test, and also cap values > 1

bit101 added a commit that referenced this pull request Oct 9, 2012

Merge pull request #31 from makc/patch-1
Fix for the bug introduced in #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment