Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass 'loss 0' to tc as it will cause an error on newer versions #882

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@stephanreiter
Copy link
Contributor

commented Jun 8, 2019

Observed on Ubuntu 18.04.

@lantz

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Thanks for the catch – if you want to fix the code check error (line too long) I can merge it.

@stephanreiter stephanreiter force-pushed the stephanreiter:master branch from dc25579 to 46242ac Jun 8, 2019

@stephanreiter

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Nice! So the line was one character too long. I fixed it by changing != 0 to > 0. Makes the code more logical also. :-)

@lantz lantz merged commit de28f67 into mininet:master Jun 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.