key: refactor key store backend API #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
force-pushed
the
key-ref
branch
2 times, most recently
from
0703f2f
to
c3904de
Compare
This commit refactors the key store API to use a new `key` package as a replacement for the `secret` package. The new `key` package is a prerequisite for further improvements for keys - i.e. typed keys, sym. vs. asym. keys etc. Further, this commit cleans up some existing code and defines the responsibilities of different types more precisely - i.e. `key.Manager` vs. `key.Store`. This commit should not cause any change in behavior. Signed-off-by: Andreas Auernhammer <hi@aead.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the key store API
to use a new
keypackage as a replacementfor the
secretpackage.The new
keypackage is a prerequisite forfurther improvements for keys - i.e. typed
keys, sym. vs. asym. keys etc.
Further, this commit cleans up some existing
code and defines the responsibilities of different
types more precisely - i.e.
key.Managervs.key.Store.This commit should not cause any change in behavior.