Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display watch help [FLAGS] before target #2220

Merged
merged 1 commit into from Jul 18, 2017
Merged

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jul 18, 2017

Fixes #2213 to standardize help message across mc commands.

@codecov-io
Copy link

codecov-io commented Jul 18, 2017

Codecov Report

Merging #2220 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2220      +/-   ##
=========================================
- Coverage    9.02%   8.81%   -0.22%     
=========================================
  Files          93      93              
  Lines        6902    9021    +2119     
=========================================
+ Hits          623     795     +172     
- Misses       6152    8099    +1947     
  Partials      127     127
Impacted Files Coverage Δ
cmd/watch-main.go 0% <ø> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/config-utils.go 73.91% <0%> (-6.09%) ⬇️
pkg/hookreader/hookreader.go 19.23% <0%> (-5.77%) ⬇️
cmd/client-url.go 56.52% <0%> (-4.8%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/config.go 20.56% <0%> (-1.4%) ⬇️
pkg/ioutils/filepath.go 13.63% <0%> (-0.91%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
pkg/console/console.go 6.4% <0%> (-0.14%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7888e...26dc314. Read the comment docs.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekoder
Copy link
Contributor

merging because code coverage report seems incorrect.

@deekoder deekoder merged commit 4753e1e into minio:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants