New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --dangerous flag for mc rb sitewide removal #2709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested
Text needs to be changed. |
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
==========================================
- Coverage 10.08% 10.08% -0.01%
==========================================
Files 129 129
Lines 12283 12288 +5
==========================================
Hits 1239 1239
- Misses 10877 10882 +5
Partials 167 167
Continue to review full report at Codecov.
|
sorry for the nit pick, but the out put is now
It will be better if we do not display the last line, it gives an impression that we are removing the alias itself. Displaying the buckets might be good enough. |
Also fix mc rb bug while deleting folders on file system
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.