Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dangerous flag for mc rb sitewide removal #2709

Merged
merged 2 commits into from Mar 12, 2019

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Mar 8, 2019

No description provided.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@kannappanr
Copy link
Collaborator

 $ mc rb --dangerous --force myminio1
Bucket removed successfully `myminio1`.

Text needs to be changed.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #2709 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2709      +/-   ##
==========================================
- Coverage   10.08%   10.08%   -0.01%     
==========================================
  Files         129      129              
  Lines       12283    12288       +5     
==========================================
  Hits         1239     1239              
- Misses      10877    10882       +5     
  Partials      167      167
Impacted Files Coverage Δ
cmd/rb-main.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e612b2...3ab7f77. Read the comment docs.

@kannappanr
Copy link
Collaborator

sorry for the nit pick, but the out put is now

$ mc rb --dangerous --force myminio1
Removed `myminio1/test` successfully.
Removed `myminio1/test1` successfully.
Removed `myminio1/test2` successfully.
Removed `myminio1` successfully.

It will be better if we do not display the last line, it gives an impression that we are removing the alias itself. Displaying the buckets might be good enough.

Also fix mc rb bug while deleting folders on file system
@poornas
Copy link
Contributor Author

poornas commented Mar 12, 2019

sorry for the nit pick, but the out put is now

$ mc rb --dangerous --force myminio1
Removed `myminio1/test` successfully.
Removed `myminio1/test1` successfully.
Removed `myminio1/test2` successfully.
Removed `myminio1` successfully.

It will be better if we do not display the last line, it gives an impression that we are removing the alias itself. Displaying the buckets might be good enough.

done.

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit e684b48 into minio:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants