Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomly generate AK and SK on mc client #4565

Merged
merged 42 commits into from May 9, 2023

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented May 5, 2023

Description

Fix #4562 without breaking minio server interface compatibility.

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@dormanze dormanze changed the title svcacct:Optimize the error information svcacct:Randomly generate AK and SK on mc client May 6, 2023
@dormanze
Copy link
Contributor Author

dormanze commented May 6, 2023

@harshavardhana Please review my pr.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana changed the title svcacct:Randomly generate AK and SK on mc client randomly generate AK and SK on mc client May 9, 2023
@harshavardhana harshavardhana merged commit ada4096 into minio:master May 9, 2023
5 checks passed
@dormanze dormanze deleted the fixSvcacct branch May 26, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'mc admin svcacct add' can't generate random secret if access-key specified
3 participants