Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some issues #243

Merged
merged 9 commits into from Oct 1, 2018
Merged

Some issues #243

merged 9 commits into from Oct 1, 2018

Conversation

SanSYS
Copy link

@SanSYS SanSYS commented Sep 10, 2018

And I think you have some problems with async/await methods
Please - try to use sonar qube or linter for your IDE https://www.sonarlint.org/

krisis
krisis approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanSYS Thank you for sending this PR :+1

@SanSYS
Copy link
Author

SanSYS commented Sep 24, 2018

so? maybe it's time to merge? )

poornas
poornas approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 03c117e into minio:master Oct 1, 2018
@SanSYS SanSYS deleted the some-issues branch October 4, 2018 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisis krisis krisis approved these changes

@poornas poornas poornas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SanSYS @krisis @poornas @kannappanr