Send single DELETE requests if object name has xml invalid chars #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is not possible to remove some objects using the multi delete API if those objects contain some weird characters. In an XML document, some characters are not allowed to be there and there is no way to escape them in XML 1.0, currently used by S3. Therefore, some objects that have those invalid characters won't be deleted in a multi-delete request. To solve this, we need to check for object names and send individual DELETE requests. The object name will be encoded in the request URL and can be removed as expected
klauspost
approved these changes
Aug 28, 2020
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to remove some objects using the multi
delete API if those objects contain some weird characters.
In an XML document, some characters are not allowed to be there and
there is no way to escape them in XML 1.0, currently used by S3.
Therefore, some objects that have those invalid characters won't be
deleted in a multi-delete request.
To solve this, we need to check for object names and send individual
DELETE requests. The object name will be encoded in the request URL and
can be removed as expected