change linter to eslint, fix codebase #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSHint as it was wasn't strict at all. JSC, on the other hand, was discontinued and continued into eslint, a very popular tool. I chose to replace them with eslint for its strictness. The tools are pretty compatible with eachother so there wasn't much of a choice to be made, they'd all work to some extent.
mostly semicolons to remove, unused variable declarations
brendanashworth
force-pushed
the
use-eslint
branch
from
05a9b78
to
de4d66b
Compare
|
@brendanashworth this is great, is there someway these indentation rules can be used by some tool like https://github.com/millermedeiros/esformatter which can indent the source? |
|
@krishnasrinivas yes! Eslint allows you to do |
krishnasrinivas
approved these changes
Jul 7, 2017
|
thanks! |
no, thank you. |
deekoder
requested review from
poornas and
harshavardhana
and removed request for
poornas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #604.
It changes the linter to eslint (now replacement for JSC). Most of the linters work the same so it's not so much about the linter but the rule choices. It also now runs
gulp lintduring CI tests.I chose rules that aligned with the current codebase, but at times when it wasn't consistent, I chose what I thought was more prevalent / looked better. For example, indentation is just a hodge podge, but it's better to have rules for it than it be different across the whole codebase. (thats why the third commit is LONG)