Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: totalDrives reported in speedTest for multiple-pools #13770

Merged
merged 1 commit into from Nov 29, 2021

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Nov 27, 2021

Description

fix: totalDrives reported in speedTest for multiple-pools

Motivation and Context

totalDrives reported in speedTest result were wrong
for multiple pools, this PR fixes this.

Bonus: add support for configurable storage-class, this
allows us to test REDUCED_REDUNDANCY to see further
maximum throughputs across the cluster.

How to test this PR?

Start MinIO server

~ minio server  --address=:9001 /tmp/speedtest{1...4} /tmp/speedtest{5...8}
~ mc admin speedtest myminio-local1/ --duration 20s --size 1MiB --concurrent 4
⠙ Running speedtest (With 1.0 MiB object size, 4 concurrency) PUT: 57 MiB/s GET: 1.0 GiB/s

MinIO 2021-11-27T03:22:40Z, 1 servers, 8 drives
PUT: 57 MiB/s, 57 objs/s
GET: 1.0 GiB/s, 1,029 objs/

Types of changes

  • Bug (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

totalDrives reported in speedTest result were wrong
for multiple pools, this PR fixes this.

Bonus: add support for configurable storage-class, this
allows us to test REDUCED_REDUNDANCY to see further
maximum throughputs across the cluster.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 99d87c5 into minio:master Nov 29, 2021
@harshavardhana harshavardhana deleted the fix-drives branch November 29, 2021 17:05
rbuchnajzer pushed a commit to rbuchnajzer/minio that referenced this pull request Dec 7, 2021
totalDrives reported in speedTest result were wrong
for multiple pools, this PR fixes this.

Bonus: add support for configurable storage-class, this
allows us to test REDUCED_REDUNDANCY to see further
maximum throughputs across the cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants