Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site replication: handle invalid endpoint errors #15499

Merged
merged 1 commit into from Aug 8, 2022
Merged

site replication: handle invalid endpoint errors #15499

merged 1 commit into from Aug 8, 2022

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Aug 8, 2022

Fixes panic if invalid config provided for site replication
Ref : #15497

Description

Motivation and Context

See referenced issue

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@poornas
site replication: handle invalid endpoint errors
27493a1 
Fixes panic if invalid config provided for site replication
Ref : minio#15497
vadmeste
vadmeste approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 2c137c0 into minio:master Aug 8, 2022
@harshavardhana harshavardhana deleted the fxpanic branch August 8, 2022 18:12
vadmeste pushed a commit to vadmeste/minio that referenced this pull request Oct 21, 2022
@poornas @minio-trusted
fix: handle invalid endpoint errors in site replication(minio#15499)
d70e89a 
fixes minio#15497
@bh4t bh4t added the bugfix label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@cniackz cniackz Awaiting requested review from cniackz

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poornas @vadmeste @harshavardhana @bh4t