-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IAM API to attach/detach policies for LDAP #16182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Uses minio/madmin-go#158 |
736bbb4
to
7a28069
Compare
klauspost
reviewed
Dec 7, 2022
c60e722
to
04f5fb4
Compare
Needs minio/pkg#50 |
04f5fb4
to
c31b9bd
Compare
PTAL Ready for review. |
c31b9bd
to
e8354ca
Compare
Mint Automation
16182-e8354ca/mint-pools.sh.log:
Deleting image on docker hub |
harshavardhana
approved these changes
Dec 9, 2022
klauspost
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new API allows to add or remove policy associations to an LDAP user or group.
This new API validates that the user or group exists in LDAP directory. For the user policy association, the user may be specified by either the login name or by full DN. For the group policy association, the full DN is required.
Motivation and Context
Add support for
mc admin idp ldap attach | detach
commands.How to test this PR?
Setup LDAP + MinIO as in https://github.com/minio/minio-iam-testing and try the attach detach commands with mc from the companion PR.
Types of changes
Checklist:
commit-id
orPR #
here)