Skip to content

Conversation

harshavardhana
Copy link
Member

Description

support if-match/if-none-match with s3 uploads

Motivation and Context

This PR supports optimistic concurrency via
if-match, if-none-match HTTP headers with s3
uploads.

A client that is performing an upload can send
the original ETag together with a conditional header
to ensure that an update will only occur if a certain
the condition has been met. For example, if the If-Match
the header is specified, MinIO verifies that the value
of the ETag specified in the update request is the
same as the ETag for the object being uploaded.

How to test this PR?

This is an extension, requires custom code
to test this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

This PR supports optimistic concurrency via
if-match, if-none-match HTTP headers with s3
uploads.

A client that is performing an upload can send
the original ETag together with a conditional header
to ensure that an update will only occur if a certain
condition has been met. For example, if the If-Match
header is specified, MinIO verifies that the value
of the ETag specified in the update request is the
same as the ETag for the object being uploaded.
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs additional check at handler - sent a commit to your branch

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 11c7ecb into minio:master Feb 7, 2023
@harshavardhana harshavardhana deleted the support-if-match branch February 7, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants