Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Remove level field in console/file loggers #3938

Merged
merged 1 commit into from Mar 23, 2017

Conversation

vadmeste
Copy link
Member

Description

Also rename fileName field in file logger to filename

Motivation and Context

Fixes #3927

How Has This Been Tested?

go test + Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Mar 20, 2017

Codecov Report

Merging #3938 into master will decrease coverage by 0.1%.
The diff coverage is 60.5%.

@@            Coverage Diff            @@
##           master   #3938      +/-   ##
=========================================
- Coverage    68.5%   68.4%   -0.11%     
=========================================
  Files         173     173              
  Lines       23315   23391      +76     
=========================================
+ Hits        15973   16000      +27     
- Misses       6299    6329      +30     
- Partials     1043    1062      +19
Impacted Files Coverage Δ
cmd/gateway-main.go 0% <0%> (ø) ⬆️
cmd/logger-console-hook.go 78.57% <100%> (-8.39%) ⬇️
cmd/config-migrate.go 60.1% <54.34%> (-0.89%) ⬇️
cmd/logger-file-hook.go 27.9% <83.33%> (+2.9%) ⬆️
cmd/config-v16.go 85.36% <88.88%> (ø)
cmd/logger.go 77.5% <0%> (-3.75%) ⬇️
cmd/fs-v1-rwpool.go 58.91% <0%> (-2.33%) ⬇️
cmd/fs-v1-background-append.go 78.52% <0%> (-1.35%) ⬇️
cmd/posix.go 73.25% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d12d...916c86f. Read the comment docs.

@vadmeste vadmeste force-pushed the move_to_config_v16 branch 3 times, most recently from 9e36bb8 to 3a0ef93 Compare March 20, 2017 17:01
@vadmeste vadmeste changed the title [WIP] config: Remove level field in console/file loggers config: Remove level field in console/file loggers Mar 20, 2017
@harshavardhana
Copy link
Member

@balamurugana need your reviews here..

@krishnasrinivas
Copy link
Contributor

@vadmeste this has conflicts

@vadmeste vadmeste changed the title config: Remove level field in console/file loggers [WIP] config: Remove level field in console/file loggers Mar 22, 2017
@vadmeste vadmeste changed the title [WIP] config: Remove level field in console/file loggers config: Remove level field in console/file loggers Mar 22, 2017
@vadmeste
Copy link
Member Author

@vadmeste this has conflicts

Conflict resolved @krishnasrinivas

@harshavardhana
Copy link
Member

@vadmeste can you resolve the conflict?

Also rename fileName field in file logger to filename
@vadmeste
Copy link
Member Author

@vadmeste can you resolve the conflict?

Done

@harshavardhana harshavardhana merged commit 11e15f9 into minio:master Mar 23, 2017
@vadmeste vadmeste deleted the move_to_config_v16 branch March 26, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: deprecate logger log levels
5 participants