New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Remove level field in console/file loggers #3938
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3938 +/- ##
=========================================
- Coverage 68.5% 68.4% -0.11%
=========================================
Files 173 173
Lines 23315 23391 +76
=========================================
+ Hits 15973 16000 +27
- Misses 6299 6329 +30
- Partials 1043 1062 +19
Continue to review full report at Codecov.
|
9e36bb8
to
3a0ef93
Compare
@balamurugana need your reviews here.. |
@vadmeste this has conflicts |
3a0ef93
to
2e4eb1a
Compare
Conflict resolved @krishnasrinivas |
@vadmeste can you resolve the conflict? |
Also rename fileName field in file logger to filename
2e4eb1a
to
916c86f
Compare
Done |
Description
Also rename fileName field in file logger to filename
Motivation and Context
Fixes #3927
How Has This Been Tested?
go test + Manually
Types of changes
Checklist: