Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket names can contain hyphen #4324

Merged
merged 2 commits into from May 19, 2017
Merged

Conversation

luomeiqin
Copy link

@luomeiqin luomeiqin commented May 11, 2017

IsValidBucketName supports hyphen in bucket name. but web error message hint without it.

Description

Add "hyphen" in the web tips while configure bucket name.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@luomeiqin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @harshavardhana, @krishnasrinivas and @balamurugana to be potential reviewers.

@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #4324 into master will increase coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4324      +/-   ##
==========================================
+ Coverage   66.61%   67.03%   +0.42%     
==========================================
  Files         176      144      -32     
  Lines       25078    23920    -1158     
==========================================
- Hits        16705    16035     -670     
+ Misses       7249     6820     -429     
+ Partials     1124     1065      -59
Impacted Files Coverage Δ
cmd/web-handlers.go 81.67% <0%> (ø) ⬆️
cmd/storage-rpc-client.go 33.94% <0%> (-40.93%) ⬇️
cmd/storage-rpc-server.go 48.27% <0%> (-27.7%) ⬇️
cmd/posix-errors.go 49.09% <0%> (-20%) ⬇️
cmd/net.go 77.61% <0%> (-7.99%) ⬇️
cmd/gateway-startup-msg.go 76.66% <0%> (-6.67%) ⬇️
cmd/server-startup-msg.go 80% <0%> (-6.54%) ⬇️
cmd/fs-v1-background-append.go 73.82% <0%> (-6.05%) ⬇️
cmd/fs-v1-rwpool.go 55.81% <0%> (-5.43%) ⬇️
cmd/lock-rpc-server.go 39.79% <0%> (-4.72%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c63afab...5487483. Read the comment docs.

Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luomeiqin , the word "hypen" needs to be changed to "hyphen" in PR title as well as the format string

@luomeiqin luomeiqin changed the title comments bucket name configration include hypen comments of bucket name configuration should be include "hypen" May 12, 2017
@luomeiqin luomeiqin changed the title comments of bucket name configuration should be include "hypen" Bucket names can contain hypen May 12, 2017
@luomeiqin luomeiqin changed the title Bucket names can contain hypen Bucket names can contain hyhpen May 19, 2017
@luomeiqin luomeiqin changed the title Bucket names can contain hyhpen Bucket names can contain hyphen May 19, 2017
@harshavardhana harshavardhana merged commit 9d98bf1 into minio:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants