Do not leave stale entries on etcd on a failed update operation

[harshavardhana]

Description

Do not leave stale entries on etcd on a failed update operation

Motivation and Context

Do not leave stale entries on etcd on a failed update operation

How Has This Been Tested?

Manually

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added unit tests to cover my changes.
• I have added/updated functional tests in mint. (If yes, add mint PR # here: )
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #6048 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6048   +/-   ##
=======================================
  Coverage   58.77%   58.77%           
=======================================
  Files         218      218           
  Lines       31485    31485           
=======================================
  Hits        18504    18504           
+ Misses      11361    11360    -1     
- Partials     1620     1621    +1

Impacted Files	Coverage Δ
cmd/xl-v1-common.go	81.66% <0%> (-3.34%)	⬇️
cmd/fs-v1-multipart.go	65.25% <0%> (-0.2%)	⬇️
cmd/retry.go	87.5% <0%> (+5.35%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a5146...7d0ab2e. Read the comment docs.

[minio-ops]

Mint Automation

Test	Result
mint-xl.sh	✔️
mint-gateway-nas.sh	✔️
mint-large-bucket.sh	✔️
mint-worm.sh	✔️
mint-fs.sh	✔️
mint-dist-xl.sh	✔️
mint-gateway-s3.sh	❌ more...
mint-gateway-azure.sh	❌ more...

6048-7d0ab2e/mint-gateway-azure.sh.log:

Running with
SERVER_ENDPOINT: minikube:31118
ACCESS_KEY:      minioazure1
SECRET_KEY:      ***REDACTED***
ENABLE_HTTPS:    0
SERVER_REGION:   us-east-1
MINT_DATA_DIR:   /mint/data
MINT_MODE:       full

To get logs, run 'docker cp 02cf50b11615:/mint/log /tmp/mint-logs'
(1/13) Running awscli tests ... done in 3 minutes and 37 seconds
(2/13) Running aws-sdk-go tests ... done in 2 seconds
(3/13) Running aws-sdk-java tests ... done in 4 seconds
(4/13) Running aws-sdk-php tests ... done in 2 minutes and 24 seconds
(5/13) Running aws-sdk-ruby tests ... done in 2 minutes and 14 seconds
(6/13) Running mc tests ... done in 33 minutes and 36 seconds
(7/13) Running minio-dotnet tests ... FAILED in 5 minutes and 58 seconds

Unhandled Exception: System.AggregateException: One or more errors occurred. (One or more errors occurred. (Minio API responded with message=Unsuccessful response from server without XML error: A task was canceled.)) ---> System.AggregateException: One or more errors occurred. (Minio API responded with message=Unsuccessful response from server without XML error: A task was canceled.) ---> Minio.Exceptions.InternalClientException: Minio API responded with message=Unsuccessful response from server without XML error: A task was canceled.
   at Minio.MinioClient.ParseError(IRestResponse response)
   at Minio.MinioClient.<>c.<.ctor>b__76_0(IRestResponse response)
   at Minio.MinioClient.HandleIfErrorResponse(IRestResponse response, IEnumerable`1 handlers, DateTime startTime)
   at Minio.MinioClient.<ExecuteTaskAsync>d__79.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Minio.MinioClient.<PutObjectAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Minio.MinioClient.<PutObjectAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Minio.Functional.Tests.FunctionalTest.<PutObject_Task>d__52.MoveNext() in /mint/run/core/minio-dotnet/FunctionalTest.cs:line 741
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Minio.Functional.Tests.FunctionalTest.<RemoveObjects_Test2>d__75.MoveNext() in /mint/run/core/minio-dotnet/FunctionalTest.cs:line 1669
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Minio.Functional.Tests.FunctionalTest.Main(String[] args) in /mint/run/core/minio-dotnet/FunctionalTest.cs:line 220

Executed 6 out of 13 tests successfully.

6048-7d0ab2e/mint-gateway-s3.sh.log:

Running with
SERVER_ENDPOINT: minikube:31200
ACCESS_KEY:      AKIAJH7GQKYNU3C2ADXA
SECRET_KEY:      ***REDACTED***
ENABLE_HTTPS:    0
SERVER_REGION:   us-east-1
MINT_DATA_DIR:   /mint/data
MINT_MODE:       full

To get logs, run 'docker cp 905ef91ee213:/mint/log /tmp/mint-logs'
(1/13) Running awscli tests ... done in 3 minutes and 28 seconds
(2/13) Running aws-sdk-go tests ... done in 2 seconds
(3/13) Running aws-sdk-java tests ... done in 5 seconds
(4/13) Running aws-sdk-php tests ... done in 2 minutes and 55 seconds
(5/13) Running aws-sdk-ruby tests ... done in 2 minutes and 1 seconds
(6/13) Running mc tests ... done in 32 minutes and 47 seconds
(7/13) Running minio-dotnet tests ... done in 6 minutes and 51 seconds
(8/13) Running minio-go tests ... FAILED in 44 minutes and 12 seconds
{
  "args": {
    "bucketName": "minio-go-test-4ew66c49v31u4zc5",
    "objectPrefix": "",
    "recursive": "true"
  },
  "duration": 1051,
  "function": "ListObjects(bucketName, objectPrefix, recursive, doneCh)",
  "message": "ListObjects doesn't return expected storage class",
  "name": "minio-go: testListObjects",
  "status": "FAIL"
}

Executed 7 out of 13 tests successfully.