New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate config-dir bring in certs-dir for TLS configuration #7033
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7033 +/- ##
=========================================
+ Coverage 51.67% 51.7% +0.02%
=========================================
Files 276 276
Lines 43585 43560 -25
=========================================
- Hits 22524 22523 -1
+ Misses 19049 19028 -21
+ Partials 2012 2009 -3
Continue to review full report at Codecov.
|
49027bd
to
22f8282
Compare
This PR is to provide indication that config-dir will be removed in future and all users should migrate to new --certs-dir option Fixes minio#7016 Fixes minio#7032
22f8282
to
95822ec
Compare
PR updated @balamurugana @poornas - PTAL |
Mint Automation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR is to provide an indication that config-dir will be removed
in future and all users should migrate to new --certs-dir option
Motivation and Context
Fixes #7016
Fixes #7032
Regression
No
How Has This Been Tested?
Start by testing the command line option by specifying new certs-dir location
Types of changes
Checklist:
mint
PR # here: )