Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the incorrect coverage badge from the docs #7651

Merged
merged 2 commits into from May 16, 2019

Conversation

ebozduman
Copy link
Contributor

The code coverage badge is decided to be removed from the docs, since the percentage number shown was incorrect. The removal is temporary until previously shown unit test coverage is going to be expanded and functional mint test coverage will also be included.

Description

Just removed the badge.

Motivation and Context

Ab's recommendation

Regression

No

How Has This Been Tested?

Reviewed the docs touched.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@minio-ops
Copy link

Mint Automation

Test Result
mint-compression-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-compression-dist-xl.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-nas.sh ✔️
mint-xl.sh more...

7651-f9c15c1/mint-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.61:30627
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp dfb9a88db126:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 6 minutes and 0 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-csepmaex4vodir",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 360015,
  "error": "XMinioServerNotInitialized: Server not initialized, please try again.\n\tstatus code: 503, request id: 159F03A68FF418EB, host id: ",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #7651 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7651      +/-   ##
==========================================
+ Coverage   46.76%   47.25%   +0.48%     
==========================================
  Files         283      295      +12     
  Lines       36665    47475   +10810     
==========================================
+ Hits        17148    22434    +5286     
- Misses      17429    22951    +5522     
- Partials     2088     2090       +2
Impacted Files Coverage Δ
cmd/disk-usage.go 78.94% <0%> (-21.06%) ⬇️
cmd/service.go 27.27% <0%> (-10.23%) ⬇️
cmd/gateway-main.go 14.95% <0%> (-7.37%) ⬇️
pkg/madmin/utils.go 16.66% <0%> (-7.15%) ⬇️
cmd/config-dir.go 40.74% <0%> (-7.09%) ⬇️
cmd/globals.go 55.88% <0%> (-7.09%) ⬇️
cmd/auth-handler.go 67.89% <0%> (-6.01%) ⬇️
cmd/server-rlimit.go 54.16% <0%> (-5.84%) ⬇️
pkg/policy/id.go 68.42% <0%> (-4.92%) ⬇️
cmd/gateway-env.go 28.57% <0%> (-4.77%) ⬇️
... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d508b...f9c15c1. Read the comment docs.

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 78be3f8 into minio:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants