-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Update on-disk storage format for users system #7949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Remaining items before making this PR ready for merge:
|
5f21df9 to
847c8d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #7949 +/- ##
==========================================
+ Coverage 44.78% 45.13% +0.34%
==========================================
Files 302 314 +12
Lines 38947 50659 +11712
==========================================
+ Hits 17442 22863 +5421
- Misses 19399 25674 +6275
- Partials 2106 2122 +16
Continue to review full report at Codecov.
|
76e52bf to
3953f9c
Compare
- Policy mapping is now at `config/iam/policydb/users/myuser1.json` and includes version. - User identity file is now versioned. - Migrate old data to the new format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested with both etcd and non-etcd scenarios
Mint Automation
7949-906e5b5/mint-large-bucket.sh.log:7949-906e5b5/mint-dist-xl.sh.log:7949-906e5b5/mint-compression-xl.sh.log: |
``` commit 7bdaf9b Author: Aditya Manthramurthy <donatello@users.noreply.github.com> Date: Wed Jul 24 17:34:23 2019 -0700 Update on-disk storage format for users system (minio#7949) ```
``` commit 7bdaf9b Author: Aditya Manthramurthy <donatello@users.noreply.github.com> Date: Wed Jul 24 17:34:23 2019 -0700 Update on-disk storage format for users system (minio#7949) ``` Bonus: fixes a bug when etcd keys were being re-encrypted.
``` commit 7bdaf9b Author: Aditya Manthramurthy <donatello@users.noreply.github.com> Date: Wed Jul 24 17:34:23 2019 -0700 Update on-disk storage format for users system (minio#7949) ``` Bonus: fixes a bug when etcd keys were being re-encrypted.
``` commit 7bdaf9b Author: Aditya Manthramurthy <donatello@users.noreply.github.com> Date: Wed Jul 24 17:34:23 2019 -0700 Update on-disk storage format for users system (minio#7949) ``` Bonus: fixes a bug when etcd keys were being re-encrypted.
``` commit 7bdaf9b Author: Aditya Manthramurthy <donatello@users.noreply.github.com> Date: Wed Jul 24 17:34:23 2019 -0700 Update on-disk storage format for users system (minio#7949) ``` Bonus: fixes a bug when etcd keys were being re-encrypted.
``` commit 7bdaf9b Author: Aditya Manthramurthy <donatello@users.noreply.github.com> Date: Wed Jul 24 17:34:23 2019 -0700 Update on-disk storage format for users system (minio#7949) ``` Bonus: fixes a bug when etcd keys were being re-encrypted.
Description
Policy mapping is now at
config/iam/policydb/users/myuser1.jsonand includes version.
User identity file is now versioned.
Migrate old data to the new format.
Motivation and Context
This change is in preparation to add the user-groups feature to MinIO server, so that server admins can create and manage user groups.
In this change, the policy mapped to a user is being moved and on disk json files are being versioned.
Migration from old format to new in included in this change.
How to test this PR?
Two things to test:
Start server on this PR, and check if users system works as before.
Start server on master, create some users. Then build this PR and start the server, and make sure users created on master are present in new version on this PR and works as expected.
Types of changes
Checklist:
commit-idorPR #here)