Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows tests #9594

Merged
merged 5 commits into from May 14, 2020
Merged

Fix Windows tests #9594

merged 5 commits into from May 14, 2020

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented May 13, 2020 •
edited

Motivation and Context

Replaces #9299

Skips ServerTest for now.

How to test this PR?

CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@klauspost
Fix Windows tests
af746de 
Replaces minio#9299

Not sure if this is too aggressive:

```
	if strings.Contains(object, "\\") {
		// Objects cannot be contain \ in Windows and is listed as `Characters to Avoid`.
		return ObjectNameInvalid{Bucket: bucket, Object: object}
	}
```
harshavardhana
harshavardhana requested changes May 13, 2020
View reviewed changes
cmd/object-api-input-checks.go Outdated Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
mint-gateway-s3.sh ❌ more...

9594-726f7d9/mint-gateway-s3.sh.log:

Running with
SERVER_ENDPOINT:      minio-dev3.minio.io:30948
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp fadcae903e98:/mint/log /tmp/mint-logs'

(1/15) Running aws-sdk-go tests ... done in 0 seconds
(2/15) Running aws-sdk-java tests ... done in 1 seconds
(3/15) Running aws-sdk-php tests ... done in 41 seconds
(4/15) Running aws-sdk-ruby tests ... done in 2 seconds
(5/15) Running awscli tests ... FAILED in 20 seconds
{
  "name": "awscli",
  "duration": 4453,
  "function": "aws --endpoint-url http://minio-dev3.minio.io:30948 s3api get-object --bucket awscli-mint-test-bucket-11508 --key awscli-mint-test-bucket-11508-object /tmp/datafile-0-b\n",
  "status": "FAIL",
  "error": "Etag mismatch for multipart 0 byte object"
}
(5/15) Running healthcheck tests ... done in 0 seconds
(6/15) Running mc tests ... done in 17 seconds
(7/15) Running minio-dotnet tests ... done in 28 seconds
(8/15) Running minio-go tests ... done in 36 seconds
(9/15) Running minio-java tests ... done in 38 seconds
(10/15) Running minio-js tests ... done in 45 seconds
(11/15) Running minio-py tests ... done in 1 minutes and 9 seconds
(12/15) Running s3cmd tests ... done in 1 minutes and 0 seconds
(13/15) Running s3select tests ... done in 1 seconds
(14/15) Running security tests ... done in 0 seconds

Executed 14 out of 15 tests successfully.

Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit ee9077d into minio:master May 14, 2020
This was referenced May 14, 2020
Closed
Closed
kannappanr
kannappanr approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klauspost klauspost deleted the fix-windows-tests branch May 14, 2020 10:54
blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
@klauspost @danochoa
fix: windows tests for all cases (minio#9594)
f5b1451 
Replaces minio#9299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@klauspost @minio-trusted @harshavardhana @kannappanr