Skip to content

fix: capacity reported usage value #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

fix: capacity reported usage value #2028

merged 1 commit into from
May 23, 2022

Conversation

harshavardhana
Copy link
Member

do not use unix-epoch to be displayed, instead
use the actual value at that epoch to be displayed.

@harshavardhana
Copy link
Member Author

To test this PR

$ gh pr checkout 2028
$ make assets && make install
$ CONSOLE_PROMETHEUS_URL=http://play.min.io:9091 CONSOLE_MINIO_REGION=us-east-1 CONSOLE_MINIO_SERVER=https://play.min.io:9000 console srv

@harshavardhana
Copy link
Member Author

Also the display box is wrong, the value here is currently "free" space instead - its reporting it as used space

@harshavardhana
fix: capacity reported usage value
dc2c366 
do not use unix-epoch to be displayed, instead
use the actual value at that epoch to be displayed.
prakashsvmx
prakashsvmx approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bexsoft
bexsoft approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft added bug this needs to be fixed needed High Priority labels May 23, 2022
@bexsoft bexsoft merged commit 48119ac into minio:master May 23, 2022
@harshavardhana harshavardhana deleted the fix-capacity branch May 23, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@bexsoft bexsoft bexsoft approved these changes

Assignees

@harshavardhana harshavardhana

Labels
bug this needs to be fixed needed High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshavardhana @dvaldivia @prakashsvmx @bexsoft