Skip to content

Show error when there's no storge classes #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

dvaldivia
Copy link
Collaborator

Screen Shot 2022-06-01 at 6 57 36 PM

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this, beside of that, works good

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
My Local kind cluster has standard by default for storageclass

@dvaldivia
Copy link
Collaborator Author

@prakashsvmx if you use kind, you can delete it to test this

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 41155b3 into minio:master Jun 2, 2022
@bexsoft bexsoft deleted the add-error-when-no-sc branch June 2, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants