Fix build after swagger codegen #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
requested review from
dvaldivia and
harshavardhana
and removed request for
dvaldivia
reivaj05
previously approved these changes
Jul 26, 2022
7 tasks
|
@cniackz Could you take a look at this? I am not able to tell how the CI failures are related to the changes in this PR. |
bexsoft
requested changes
Jul 26, 2022
There was a problem hiding this comment.
I'm not able to run / build console server by the following error:
# github.com/mattn/go-ieproxy
../../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.7/ieproxy.go:36:9: undefined: getConf
../../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.7/ieproxy.go:41:9: undefined: reloadConf
../../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.7/ieproxy.go:48:2: undefined: overrideEnvWithStaticProxy
../../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.7/ieproxy.go:53:13: psc.findProxyForURL undefined (type *ProxyScriptConf has no field or method findProxyForURL, but does have FindProxyForURL)
This doesn't seem to happen on my system. Not sure why all the deps got upgraded, will see if I can downgrade and update the PR. @bexsoft |
|
@bexsoft Could you try now? |
|
Issue with deps fixed. Testing |
bexsoft
approved these changes
Jul 27, 2022
reivaj05
approved these changes
Jul 27, 2022
bexsoft
requested changes
Jul 28, 2022
|
The remaining failure is expected as changes in minio are required. There is a linked PR. We can take this in. |
bexsoft
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the changes to the swagger generated files.