Skip to content

Added Color customization to embedded object browser #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Aug 13, 2022

What does this do?

Implements custom color support for embedded object browser.

To test:

  • Make assets
  • Start browser in embedded mode, include one more query param called ov_st which will contain a base64 encoded string of the following JSON:
{
  "backgroundColor": "#2787c6",
  "fontColor": "#ff0",
  "buttonStyles": {
    "backgroundColor": "#edeaa8",
    "textColor": "#2b2a2a",
    "hoverColor": "#edeaa8",
    "hoverText": "#2b2a2a",
    "activeColor": "#edeaa8",
    "activeText": "#2b2a2a"
  }
}

NOTES: Button colors may not be consistent, this will be handled during the replacement of buttons with mds system. this same case applied for application titles.

How does it look?

Screen Shot 2022-08-12 at 23 35 10

Screen Shot 2022-08-12 at 23 35 03

Screen Shot 2022-08-12 at 23 34 56

Signed-off-by: Benjamin Perez benjamin@bexsoft.net

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft force-pushed the eob-colors-customization branch from 63ad50b to 1354d9f Compare August 17, 2022 03:48
@bexsoft bexsoft requested a review from kaankabalak August 17, 2022 03:49
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Changes look good to me.
👍

Note: we need to instruct that html color names like red , blue etc... are not supported as mui does not support it. using it would lead to crash and blank screen. @bexsoft
The following formats are supported: #nnn, #nnnnnn, rgb(), rgba(), hsl(), hsla(), color().

image

@bexsoft
Copy link
Collaborator Author

bexsoft commented Aug 17, 2022

Will work on this in the ENV styles color support PR

@bexsoft bexsoft merged commit 7036d13 into minio:master Aug 17, 2022
@bexsoft bexsoft deleted the eob-colors-customization branch August 30, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants