read license from envt variable #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhaashish
requested review from
Alevsk,
dvaldivia,
prakashsvmx,
kannappanr,
bexsoft and
harshavardhana
sinhaashish
force-pushed
the
skip-admin-validation
branch
from
022bb3f to
33a873e
Compare
7 tasks
sinhaashish
force-pushed
the
skip-admin-validation
branch
from
33a873e to
538c045
Compare
bexsoft
requested changes
Aug 23, 2022
sinhaashish
force-pushed
the
skip-admin-validation
branch
from
856c0fe to
cd2a85f
Compare
kannappanr
previously approved these changes
Aug 24, 2022
bexsoft
requested changes
Aug 25, 2022
sinhaashish
force-pushed
the
skip-admin-validation
branch
4 times, most recently
from
b7ad4d9 to
564104a
Compare
sinhaashish
force-pushed
the
skip-admin-validation
branch
from
564104a to
0cc79eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the license were read from config , and only admin had the privilige to read those the config , so any normal user with read write permission were seeing AGPL license even when they had the license .
With this PR the license is being read from envt variable which is set in MinIO at initialization.