Add hover effect to Notification type selector buttons #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
pjuarezd,
reivaj05,
dvaldivia,
kaankabalak,
bexsoft and
oscarocastellanos
kaankabalak
previously approved these changes
Dec 12, 2022
|
I think we also need a hover of color so the user can feel the mouse is over the whole box |
reivaj05
previously approved these changes
Dec 12, 2022
jinapurapu
changed the title
jinapurapu
dismissed stale reviews from reivaj05 and kaankabalak
via
611588d
jinapurapu
force-pushed
the
notification_target_hover
branch
from
cb9c983 to
611588d
Compare
added 2 commits
December 13, 2022 12:48
bexsoft
requested changes
Dec 14, 2022
portal-ui/src/screens/Console/NotificationEndpoints/NotificationTypeSelector.tsx
Outdated
Show resolved
Hide resolved
bexsoft
approved these changes
Dec 14, 2022
kaankabalak
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-12-13.at.12.45.19.PM.mov
Closes https://github.com/miniohq/engineering/issues/715