-
Notifications
You must be signed in to change notification settings - Fork 426
Move Register Component to Redux #2630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0a9fec2
to
257e2bf
Compare
@dvaldivia could you please resolve the conflicts ? |
257e2bf
to
792f392
Compare
resolved @prakashsvmx |
@dvaldivia
|
@prakashsvmx can you also test on master? I think it's also broken there, I'll debug this and try to come up with a fix |
@prakashsvmx I've verified the same problem happens on master, will address it either in this PR or a separate one |
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
afdf21d
to
a760fb6
Compare
@prakashsvmx issue has been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor review comment.
Tested the following Flows: Changes look Good to me 👍
MinIO Console
- Online Registration
- API Key Registration
- Air-Gap Registration
Operator Console
- API Key Registration
const offlineRegUrl = `https://subnet.min.io/cluster/register?token=${subnetRegToken}`; | ||
|
||
return ( | ||
<Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Fragment> | |
<Fragment> | |
<Box | |
sx={{ | |
border: "1px solid #eaeaea", | |
borderRadius: "2px", | |
display: "flex", | |
flexFlow: "column", | |
padding: "43px", | |
}} | |
> | |
{clusterRegistered && licenseInfo ? ( | |
<ClusterRegistered email={licenseInfo.email} /> | |
) : ( | |
<Fragment> | |
<Box | |
sx={{ | |
"& .title-text": { | |
marginLeft: "27px", | |
fontWeight: 600, | |
}, | |
}} | |
> | |
<FormTitle | |
icon={<OfflineRegistrationIcon />} | |
title={`Register cluster in an Air-gap environment`} | |
/> | |
</Box> | |
<Box | |
sx={{ | |
display: "flex", | |
}} | |
> | |
<Box | |
sx={{ | |
display: "flex", | |
flexFlow: "column", | |
flex: "2", | |
marginTop: "15px", | |
"& .step-number": { | |
color: "#ffffff", | |
height: "25px", | |
width: "25px", | |
background: "#081C42", | |
marginRight: "10px", | |
textAlign: "center", | |
fontWeight: 600, | |
borderRadius: "50%", | |
}, | |
"& .step-row": { | |
fontSize: "16px", | |
display: "flex", | |
marginTop: "15px", | |
marginBottom: "15px", | |
}, | |
}} | |
> | |
<Box> | |
<Box className="step-row"> | |
<div className="step-text"> | |
Click on the link to register this cluster in SUBNET | |
</div> | |
</Box> | |
<Box | |
sx={{ | |
flex: "1", | |
display: "flex", | |
alignItems: "center", | |
gap: 3, | |
}} | |
> | |
<Link | |
style={{ | |
color: "#2781B0", | |
cursor: "pointer", | |
}} | |
color="inherit" | |
href={offlineRegUrl} | |
target="_blank" | |
> | |
https://subnet.min.io/cluster/register | |
</Link> | |
<TooltipWrapper tooltip={"Copy to Clipboard"}> | |
<CopyToClipboard text={offlineRegUrl}> | |
<Button | |
type={"button"} | |
id={"copy-ult-to-clip-board"} | |
icon={<CopyIcon />} | |
color={"primary"} | |
variant={"regular"} | |
/> | |
</CopyToClipboard> | |
</TooltipWrapper> | |
</Box> | |
<div | |
style={{ | |
marginTop: "25px", | |
fontSize: "14px", | |
fontStyle: "italic", | |
color: "#5E5E5E", | |
}} | |
> | |
If this machine does not have internet connection, Copy | |
paste the following URL in a browser where you access SUBNET | |
and follow the instructions to complete the registration | |
</div> | |
</Box> | |
</Box> | |
<RegisterHelpBox /> | |
</Box> | |
</Fragment> | |
)} | |
</Box> | |
</Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the cluster is registered in Air-Gap mode, the registration instructions could be hidden like other methods.
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com