Skip to content

Disable Audit Log and Monitoring by default #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shtripat
Copy link
Contributor

@shtripat shtripat commented Feb 3, 2023

While tenant creation, by default keep the Audit Log and Monitoring option disabled

Steps for testing are as below

Step-1: Clone the repo https://github.com/shtripat/minio-console.git and clone the branch [disable-log-and-monitoring-by-default](https://github.com/shtripat/minio-console/tree/disable-log-and-monitoring-by-default)
Step-2: Build the docker image for the console project

✘ docker build --output=type=docker --platform linux/amd64 -t minio/console:test-version-shubhendu-dev --build-arg build_version=test-version-shubhendu --build-arg NODE_VERSION=18 .

Step-3: Tag the build to push to personal docker hub repository

✘ docker tag minio/console:test-version-shubhendu-dev   shtripat/minio:test-version-shubhendu-dev

Step-4: Push the local docker image to the personal docker hub repository

✘ docker push shtripat/minio:test-version-shubhendu-dev

Step-5: Create a local kind cluster

✘ kind create cluster --config kind-config.yaml

The content of kind-config.yaml

kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
  - role: control-plane
  - role: worker
  - role: worker
  - role: worker
  - role: worker

Step-6: Install the minio operator to the kind cluster with console image from private docker hub repository

✘ k minio init --console-image shtripat/minio:test-version-shubhendu-dev

Step-7: Start a port forward to the operator UI

✘ k minio proxy

Step-8: Login to the operator console using the JWT token shown in above step and click the option Create a Tenant. The tabs Audit Log and Monitoring should be disabled by default
Screenshot from 2023-02-06 16-31-29

Screenshot from 2023-02-06 16-31-39

While tenant creation, by default keep the Audit Log and Monitoring option disabled

Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM 👍

@pjuarezd
Copy link
Member

pjuarezd commented Feb 6, 2023

@bexsoft @jinapurapu @reivaj05 can you take a look please?

@dvaldivia dvaldivia merged commit 900b8d9 into minio:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants