Product license verification in Console #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 15, 2020
Closed
cesnietor
reviewed
Dec 18, 2020
|
If the errors are informative we should return them as well : |
Alevsk
force-pushed
the
subnet-integration
branch
2 times, most recently
from
f0a9ac7 to
d65783e
Compare
Alevsk
force-pushed
the
subnet-integration
branch
3 times, most recently
from
c916b57 to
42fc6ff
Compare
Added validation so the buttons are disabled if the input fields are empty |
Alevsk
force-pushed
the
subnet-integration
branch
2 times, most recently
from
df6666d to
d6aebd6
Compare
Alevsk
changed the title
bexsoft
requested changes
Dec 23, 2020
portal-ui/src/screens/Console/NotificationEndopoints/AddNotificationEndpoint.tsx
Outdated
Show resolved
Hide resolved
Alevsk
force-pushed
the
subnet-integration
branch
from
919ebef to
eab6292
Compare
Alevsk
force-pushed
the
subnet-integration
branch
from
eab6292 to
409dbeb
Compare
dvaldivia
requested changes
Jan 4, 2021
| @@ -1,5 +1,5 @@ | |||
| // This file is part of MinIO Console Server | |||
| // Copyright (c) 2019 MinIO, Inc. | |||
| // Copyright (c) 2020 MinIO, Inc. | |||
There was a problem hiding this comment.
if you are mass replacing files with this, perhaps let's go to 2021 xD
There was a problem hiding this comment.
I think this change must be done after we merge log search & prometheus functionality to avoid multiple merge conflicts
There was a problem hiding this comment.
2021 all the things!
dvaldivia
previously approved these changes
Jan 11, 2021
Operator UI - Provide and store License key - New License section in Operator UI will allow user to provide the license key via input form - New License section in Operator UI will allow the user to fetch the license key using subnet credentials - Console backend has to verify provided license is valid - https://godoc.org/github.com/minio/minio/pkg/licverifier#example-package - Console backend has to store the license key in k8s secrets Operator UI - Set license to tenant during provisioning - Check if license key exists in k8s secret during tenant creation - If License is present attach the license-key jwt to the new console tenant via an environment variable Operator UI - Set license for an existing tenant - Tenant view will display information about the current status of the Tenant License - If Tenant doesn't have a License then Operator-UI will allow to attach new license by clicking the Add License button - Console backend will extract the license from the k8s secret and save the license-key jwt in the tenant console environment variable and redeploy
Alevsk
force-pushed
the
subnet-integration
branch
from
409dbeb to
ab91f24
Compare
dvaldivia
approved these changes
Jan 11, 2021
dvaldivia
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Operator UI - Provide and store License key
license key via input form
license key using subnet credentials
https://godoc.org/github.com/minio/minio/pkg/licverifier#example-package
Operator UI - Set license to tenant during provisioning
tenant via an environment variable
Operator UI - Set license for an existing tenant
Tenant License
new license by clicking the Add License button
the license-key jwt in the tenant console environment variable and
redeploy
How it looks
Display license information in Operator-ui
Activate Product button
Activate Product Modal in Operator-ui
Tenant Information - Product Activated
Tenant Information - License exists in k8s but tenant is not activated
Tenant Information - Tenant is not activated and License is not present in k8s