Add Bucket Locking option and fix versioning configuration. #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
force-pushed
the
add-bucket-object-locking
branch
from
baf846c to
f3c75cf
Compare
bexsoft
requested changes
Mar 22, 2021
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket.tsx
Outdated
Show resolved
Hide resolved
|
Hi! The 3 lines below features should have a lighter gray color, since those are dividers and not actionable (as the input line above). I would suggest to use ##eaeaea for the lines as dividers (and apply the same to all similar cases) |
Sure! I will file a new ticket for it |
|
Are the json changes necessary? |
In this case, yes, as these files are auto generated by |
|
@bexsoft done
|
|
Object Locking Enabled Object Locking Disabled
|
|
|
bexsoft
approved these changes
Mar 22, 2021
adfost
pushed a commit
to adfost/console
that referenced
this pull request
Mar 24, 2021
continuing rebase# This is a combination of 2 commits. continuing rebase # This is a combination of 5 commits.tree 03d4bd0e2d374d903f129ab8fe42344cb8fb7dbb parent 934e8c9 author Adam Stafford <adamstafford@MacBook-Pro-van-Adam-2.local> 1616022296 -0700 committer Adam Stafford <adam@minio.io> 1616543805 -0700 squashing part 2 This is a combination of 6 commits. squashing all comits# This is a combination of 13 commits. api for listing policies attatched to a bucket Reverting go.mod and go.sum. removing admin.json getting rid of ./swagger Attempting to add blank line deleting commented code new menu adding ViewBucket.tsx Bug fix with screens Removing debug print statement Committing types.tsx api for listing policies attatched to a bucket (minio#660) api for listing policies attatched to a bucket Added versioning edit in console (minio#645) Bump react-dev-utils from 11.0.1 to 11.0.4 in /portal-ui (minio#644) Bumps [react-dev-utils](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-dev-utils) from 11.0.1 to 11.0.4. - [Release notes](https://github.com/facebook/create-react-app/releases) - [Changelog](https://github.com/facebook/create-react-app/blob/master/CHANGELOG-1.x.md) - [Commits](https://github.com/facebook/create-react-app/commits/HEAD/packages/react-dev-utils) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Valdivia <hola@danielvaldivia.com> Allow to assign multiple policies to to a user or group (minio#646) * Allow to assign multiple policies to to a user or group * Latest assets console license page improvements and fixes (minio#647) - fixed issue when deploying tenant with tls disabled - applied new design for tenant details and license screens - added license refresh job to operator console - added new refresh license endpoint - console operator not longer store CONSOLE_ACCESS_KEY and CONSOLE_SECRET_KEY values in the tenant-console-secret Co-authored-by: Daniel Valdivia <hola@danielvaldivia.com> Interactive Feedback when list objects take a long time (minio#655) * Interactive Feedback when list objects take a long time * Remove cancel button Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Add Bucket Locking option and fix versioning configuration. (minio#661) * Add Bucket Locking option and fix versioning configuration. * Addres comments * Rework the View Bucket options * Remove extra padding Update ViewBucket.tsx Update portal-ui/src/screens/Console/Buckets/ViewBucket/PolicySelectors.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Update ViewBucket.tsx Deleting unnecessary files update ldap development example (minio#664)
adfost
pushed a commit
to adfost/console
that referenced
this pull request
Mar 24, 2021
…5d49cb82c7a795d681469486d6961008d665fded parent e088431 author Adam Stafford <adamstafford@MacBook-Pro-van-Adam-2.local> 1616022296 -0700 committer Adam Stafford <adam@minio.io> 1616606382 -0700 Adding UI to Bucket Policy Adding UI for bucket policy Adding UI for Bucket Policy API api for listing policies attatched to a bucket (minio#660) api for listing policies attatched to a bucket Added versioning edit in console (minio#645) Bump react-dev-utils from 11.0.1 to 11.0.4 in /portal-ui (minio#644) Bumps [react-dev-utils](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-dev-utils) from 11.0.1 to 11.0.4. - [Release notes](https://github.com/facebook/create-react-app/releases) - [Changelog](https://github.com/facebook/create-react-app/blob/master/CHANGELOG-1.x.md) - [Commits](https://github.com/facebook/create-react-app/commits/HEAD/packages/react-dev-utils) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Valdivia <hola@danielvaldivia.com> Allow to assign multiple policies to to a user or group (minio#646) * Allow to assign multiple policies to to a user or group * Latest assets console license page improvements and fixes (minio#647) - fixed issue when deploying tenant with tls disabled - applied new design for tenant details and license screens - added license refresh job to operator console - added new refresh license endpoint - console operator not longer store CONSOLE_ACCESS_KEY and CONSOLE_SECRET_KEY values in the tenant-console-secret Co-authored-by: Daniel Valdivia <hola@danielvaldivia.com> Interactive Feedback when list objects take a long time (minio#655) * Interactive Feedback when list objects take a long time * Remove cancel button Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Add Bucket Locking option and fix versioning configuration. (minio#661) * Add Bucket Locking option and fix versioning configuration. * Addres comments * Rework the View Bucket options * Remove extra padding Update ViewBucket.tsx Update portal-ui/src/screens/Console/Buckets/ViewBucket/PolicySelectors.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Update ViewBucket.tsx Deleting unnecessary files update ldap development example (minio#664) removing admin.json getting rid of ./swagger Attempting to add blank line deleting commented code new menu adding ViewBucket.tsx Bug fix with screens Removing debug print statement Committing types.tsx Update ViewBucket.tsx Update portal-ui/src/screens/Console/Buckets/ViewBucket/PolicySelectors.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Update portal-ui/src/screens/Console/Buckets/ViewBucket/PolicySelectors.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Update portal-ui/src/screens/Console/Buckets/ViewBucket/PolicySelectors.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Update portal-ui/src/screens/Console/Buckets/ViewBucket/PolicySelectors.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com> Deleting unnecessary files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to turn locking for any bucket with versioning features, not we only turn it on if there's retention configured or explicitly on, this means that we can have buckets with versioning enabled only