Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: run asmfmt #24

Merged
merged 2 commits into from
Jan 8, 2021
Merged

all: run asmfmt #24

merged 2 commits into from
Jan 8, 2021

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Jan 6, 2021

Run github.com/klauspost/asmfmt/cmd/asmfmt.

Note that only find_odd_backslash_sequences_amd64.s file was self-edted after run asmfmt because there are Y8 => (DI) and Y9 => (SI) inline hints.

	VPCMPEQB  Y8/*(DI)*/, Y0, Y1  // vpcmpeqb    ymm1, ymm0, yword [rdi]
	VPMOVMSKB Y1, CX              // vpmovmskb    ecx, ymm1
	VPCMPEQB  Y9/*(SI)*/, Y0, Y0  // vpcmpeqb    ymm0, ymm0, yword [rsi]

@zchee
all: run asmfmt
b8f0983 
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee
Copy link
Contributor Author

zchee commented Jan 6, 2021 •
edited
Loading

@klauspost BTW, asmfmt seems doesn't support inline C style comment (actually, was added newline so might be can't compile(?)), do you have any plan support them?

@klauspost
Copy link
Collaborator

@zchee Yeah, that looks strange indeed.

klauspost added a commit to klauspost/asmfmt that referenced this pull request Jan 6, 2021
@klauspost
Fix c comment before line comment
c440dd6 
Fixes issue in minio/simdjson-go#24
@klauspost klauspost mentioned this pull request Jan 6, 2021
Merged
@klauspost klauspost closed this Jan 6, 2021
@klauspost klauspost reopened this Jan 6, 2021
@klauspost
Copy link
Collaborator

See linked issue.

@zchee
Copy link
Contributor Author

zchee commented Jan 6, 2021

@klauspost Thanks quickly! Fixed inline comment issue and reformat find_odd_backslash_sequences_amd64.s: 2847046 (#24)

klauspost added a commit to klauspost/asmfmt that referenced this pull request Jan 6, 2021
@klauspost
Fix c comment before line comment (#37)
5efd4a9 
* Fix c comment before line comment
* Update travis
* Update doc+badge

Fixes issue in minio/simdjson-go#24
@zchee
Copy link
Contributor Author

zchee commented Jan 8, 2021

@klauspost sorry, just ping.

@klauspost klauspost merged commit fcc30eb into minio:master Jan 8, 2021
@zchee zchee deleted the asmfmt branch January 8, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zchee @klauspost