New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create multiple Minishift clusters #126

Closed
jorgemoralespou opened this Issue Oct 19, 2016 · 46 comments

Comments

Projects
None yet
6 participants
@jorgemoralespou
Contributor

jorgemoralespou commented Oct 19, 2016

Would it be possible to have different named clusters, so I can start/stop the cluster I want?

It would be nice to have a workflow that could enable this:

minishift start my-example-cluster
minishift stop

minishift start my-minimal-cluster
minishift stop

minishift start my-example-cluster
minishift stop

minishift delete my-example-cluster
@LalatenduMohanty

This comment has been minimized.

Show comment
Hide comment
@LalatenduMohanty

LalatenduMohanty Oct 20, 2016

Member

Good idea. But as per my understanding it wont be easy or trivial. So the question is what is the priority of this feature.

Member

LalatenduMohanty commented Oct 20, 2016

Good idea. But as per my understanding it wont be easy or trivial. So the question is what is the priority of this feature.

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou Oct 20, 2016

Contributor

Why can't be easy? Don't have to be running at the same time, but as long as you give the machine a name you can create multiple machines.

Contributor

jorgemoralespou commented Oct 20, 2016

Why can't be easy? Don't have to be running at the same time, but as long as you give the machine a name you can create multiple machines.

@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson

jimmidyson Oct 20, 2016

Member

If it's so easy then I wait for your contribution :-b

It's definitely doable, just need to refactor stuff a bit. I'm sure this would be useful upstream as well btw.

Member

jimmidyson commented Oct 20, 2016

If it's so easy then I wait for your contribution :-b

It's definitely doable, just need to refactor stuff a bit. I'm sure this would be useful upstream as well btw.

@LalatenduMohanty

This comment has been minimized.

Show comment
Hide comment
@LalatenduMohanty

LalatenduMohanty Oct 21, 2016

Member

@jorgemoralespou I think thats good news. If you can give the steps, I can try to put in minishift.

Member

LalatenduMohanty commented Oct 21, 2016

@jorgemoralespou I think thats good news. If you can give the steps, I can try to put in minishift.

@budhram

This comment has been minimized.

Show comment
Hide comment
@budhram

budhram Oct 21, 2016

Member

+1 for the idea @jorgemoralespou

Member

budhram commented Oct 21, 2016

+1 for the idea @jorgemoralespou

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou Oct 23, 2016

Contributor

@jimmidyson I would contribute if I knew go.
The only thing I can do is blog about my thoughts and how I would like this to work. I have it working with oc cluster up although not the tool. Just a workaround for me for now.

Since I know you've already read it. I leave it here for others:
http://jorgemoral.es/2016/10/developing-locally-with-openshift/

Contributor

jorgemoralespou commented Oct 23, 2016

@jimmidyson I would contribute if I knew go.
The only thing I can do is blog about my thoughts and how I would like this to work. I have it working with oc cluster up although not the tool. Just a workaround for me for now.

Since I know you've already read it. I leave it here for others:
http://jorgemoral.es/2016/10/developing-locally-with-openshift/

@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson

jimmidyson Oct 23, 2016

Member

I really love that post - you've explained the use cases for each of your requirements really clearly, thank you. One thing we've talked about is trying to keep minishift ux as close to minikube's as possible. With that in mind, would you be able to raise an issue in https://github.com/kubernetes/minikube/issues with a similar discussion?

Member

jimmidyson commented Oct 23, 2016

I really love that post - you've explained the use cases for each of your requirements really clearly, thank you. One thing we've talked about is trying to keep minishift ux as close to minikube's as possible. With that in mind, would you be able to raise an issue in https://github.com/kubernetes/minikube/issues with a similar discussion?

@jimmidyson

This comment has been minimized.

Show comment
Hide comment
@jimmidyson

jimmidyson Oct 23, 2016

Member

Next step will be to break down your post into separate issues & then we'll be able to start working towards them. Help to raise those issues, discuss the details & review the implementations would be awesome contributions - & there were you saying you couldn't contribute because it's written in go 😜

Member

jimmidyson commented Oct 23, 2016

Next step will be to break down your post into separate issues & then we'll be able to start working towards them. Help to raise those issues, discuss the details & review the implementations would be awesome contributions - & there were you saying you couldn't contribute because it's written in go 😜

@hferentschik hferentschik changed the title from would it be possible to have multiple clusters created? to Would it be possible to have multiple clusters created? Nov 4, 2016

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou
Contributor

jorgemoralespou commented Dec 2, 2016

For reference: kubernetes/minikube#886

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou Dec 2, 2016

Contributor

Also, I've seen minikube supports addons, which is similar to the plugins we do support in oc-cluster -wrapper. Does minishift support addons?
Most of the rest of my write up can be provided via addons, as I do in the wrapper, so only opening the previous issue for now.

Contributor

jorgemoralespou commented Dec 2, 2016

Also, I've seen minikube supports addons, which is similar to the plugins we do support in oc-cluster -wrapper. Does minishift support addons?
Most of the rest of my write up can be provided via addons, as I do in the wrapper, so only opening the previous issue for now.

@hferentschik hferentschik changed the title from Would it be possible to have multiple clusters created? to Possibilty to have multiple clusters created Dec 19, 2016

@budhram budhram added kind/feature and removed kind/question labels Jan 20, 2017

@hferentschik hferentschik added this to the v2.0.0 milestone Feb 10, 2017

@hferentschik

This comment has been minimized.

Show comment
Hide comment
@hferentschik

hferentschik Mar 16, 2017

Member

There is a discussion ongoing on Minikube on how this should look like from an ux perspective - kubernetes/minikube#886

Member

hferentschik commented Mar 16, 2017

There is a discussion ongoing on Minikube on how this should look like from an ux perspective - kubernetes/minikube#886

@hferentschik hferentschik modified the milestones: v1.2.0, v2.0.0 May 3, 2017

@hferentschik

This comment has been minimized.

Show comment
Hide comment
@hferentschik

hferentschik May 3, 2017

Member

Seems Minikube went ahead and implemented something - kubernetes/minikube#1320 (comment)

Member

hferentschik commented May 3, 2017

Seems Minikube went ahead and implemented something - kubernetes/minikube#1320 (comment)

@budhram

This comment has been minimized.

Show comment
Hide comment
@budhram
Member

budhram commented May 3, 2017

Yes @hferentschik :)

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou May 3, 2017

Contributor
Contributor

jorgemoralespou commented May 3, 2017

@hferentschik

This comment has been minimized.

Show comment
Hide comment
@hferentschik

hferentschik May 3, 2017

Member

I find it complex how to switch the active profile/VM

+1 I am not a big fan yet either. We need to test drive with Minikube a bit and see how much we want to align. As we discussed with other related issues, there is a tradeoff between providing a user a smooth transition between Minikube and Minishift and having a potentially better ux.

Right now my biggest concern is the re-use of 'config set'. I think it would have been better to have dedicated commands there.

Anyways, it has landed. So we need in a first step evaluate it, see how much we can potentially re-use and last but not least decide whether we want to (at least partly) go different ways.

Member

hferentschik commented May 3, 2017

I find it complex how to switch the active profile/VM

+1 I am not a big fan yet either. We need to test drive with Minikube a bit and see how much we want to align. As we discussed with other related issues, there is a tradeoff between providing a user a smooth transition between Minikube and Minishift and having a potentially better ux.

Right now my biggest concern is the re-use of 'config set'. I think it would have been better to have dedicated commands there.

Anyways, it has landed. So we need in a first step evaluate it, see how much we can potentially re-use and last but not least decide whether we want to (at least partly) go different ways.

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou May 3, 2017

Contributor
Contributor

jorgemoralespou commented May 3, 2017

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou May 10, 2017

Contributor

This seems to have been addressed. They changed from --name to --profile (-p) and added a command "profile".

I'm flattered.

kubernetes/minikube#1466

Contributor

jorgemoralespou commented May 10, 2017

This seems to have been addressed. They changed from --name to --profile (-p) and added a command "profile".

I'm flattered.

kubernetes/minikube#1466

@hferentschik

This comment has been minimized.

Show comment
Hide comment
@hferentschik

hferentschik May 11, 2017

Member

This seems to have been addressed. They changed from --name to --profile (-p) and added a command "profile".

+1 yeah. Good stuff.

Member

hferentschik commented May 11, 2017

This seems to have been addressed. They changed from --name to --profile (-p) and added a command "profile".

+1 yeah. Good stuff.

@gbraad

This comment has been minimized.

Show comment
Hide comment
@gbraad

gbraad May 31, 2017

Member

Minikube supports multiple instances from kubernetes/minikube#1320 => kubernetes/minikube#1466

Member

gbraad commented May 31, 2017

Minikube supports multiple instances from kubernetes/minikube#1320 => kubernetes/minikube#1466

@jorgemoralespou

This comment has been minimized.

Show comment
Hide comment
@jorgemoralespou

jorgemoralespou May 31, 2017

Contributor

@hferentschik @gbraad I would consider looking at this feature, as to enable this, a lot of things related to config and addons would probably need to change. Configuration should now be per-cluster and not global, as well as addons enablement, etc...

Contributor

jorgemoralespou commented May 31, 2017

@hferentschik @gbraad I would consider looking at this feature, as to enable this, a lot of things related to config and addons would probably need to change. Configuration should now be per-cluster and not global, as well as addons enablement, etc...

@hferentschik

This comment has been minimized.

Show comment
Hide comment
@hferentschik

hferentschik May 31, 2017

Member

It is scheduled for the next sprint. I also envision this to cause quite some changes.

Member

hferentschik commented May 31, 2017

It is scheduled for the next sprint. I also envision this to cause quite some changes.

@budhram

This comment has been minimized.

Show comment
Hide comment
@budhram

budhram May 31, 2017

Member

to enable this, a lot of things related to config and addons would probably need to change.

I feel the same.

Configuration should now be per-cluster and not global, as well as addons enablement, etc...

+1. Most of the major changes will happen around this.

Member

budhram commented May 31, 2017

to enable this, a lot of things related to config and addons would probably need to change.

I feel the same.

Configuration should now be per-cluster and not global, as well as addons enablement, etc...

+1. Most of the major changes will happen around this.

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 13, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Fix for review comments
Temporary commit.

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 15, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Sep 18, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

budhram added a commit that referenced this issue Sep 18, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

budhram added a commit that referenced this issue Sep 18, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

budhram added a commit that referenced this issue Sep 18, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@budhram

This comment has been minimized.

Show comment
Hide comment
@budhram

budhram Sep 18, 2017

Member

Resolved via #1380

Member

budhram commented Sep 18, 2017

Resolved via #1380

@budhram budhram closed this Sep 18, 2017

agajdosi added a commit to agajdosi/minishift that referenced this issue Sep 26, 2017

Issue #126 Ability to create multiple instances of Minishift
Introducing --profile to minishift start and profile command

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

agajdosi added a commit to agajdosi/minishift that referenced this issue Sep 26, 2017

Issue #126 Removing the static UUID for xhyve
Static UUID do not let user create multiple minishift instance. Also the plugin has ability to generate UUID

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

agajdosi added a commit to agajdosi/minishift that referenced this issue Sep 26, 2017

Issue #126 Adding integration tests for profile
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment