Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon: how to retrieve a value from an internal variable ? #1960

Closed
abouchama opened this Issue Feb 1, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@abouchama
Copy link

abouchama commented Feb 1, 2018

General information

  • Minishift version: v1.11.0+4459917
  • OS: Linux
  • Hypervisor: KVM

Steps to reproduce

Trying to create a new addon, the diffuculty that i have is that i run an
oc create -f oauthclient.yml
in order to set oauthclient and after i use the token generated to create my application:

oc new-app dev \
-p OPENSHIFT_OAUTH_CLIENT_SECRET=$(oc sa get-token oauth-client)

the oc new-app take the following value $(oc sa get-token oauth-client) that's set on the oc create -f

Is there any way to make this as an internal variable
OPENSHIFT_OAUTH_CLIENT_SECRET=$(oc sa get-token oauth-client) ?

Thanks,

@coolbrg

This comment has been minimized.

Copy link
Member

coolbrg commented Feb 1, 2018

Is there any way to make this as an internal variable
OPENSHIFT_OAUTH_CLIENT_SECRET=$(oc sa get-token syndesis-oauth-client) ?

I think this type of requirement make sense.

@LalatenduMohanty

This comment has been minimized.

Copy link
Member

LalatenduMohanty commented Feb 14, 2018

Wondering how we have not come across this yet. cc @jorgemoralespou

@jorgemoralespou

This comment has been minimized.

Copy link
Contributor

jorgemoralespou commented Feb 14, 2018

@LalatenduMohanty probably because current addons are simple. In my wrapper, addons are implemented as bash scripts andI use this functionality a lot, but also conditionals, which to me are more priority. But yes, definitely there's some script like features required for addons.
Is there a place where requirements for addons can be seen in a roadmap/timeline type of way?

@LalatenduMohanty

This comment has been minimized.

Copy link
Member

LalatenduMohanty commented Feb 15, 2018

@jorgemoralespou You can see all add-ons related issues in https://github.com/minishift/minishift/labels/component%2Faddons
I agree that we have a substantial backlog of add-ons .

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.14.0, v1.15.0 Feb 16, 2018

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.15.0, v1.16.0 Mar 6, 2018

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.16.0, v1.17.0 Mar 28, 2018

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.17.0, v1.18.0 Apr 19, 2018

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.18.0, v1.19.0 May 10, 2018

@praveenkumar praveenkumar self-assigned this Jun 11, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 11, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 11, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 11, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 12, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 15, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 15, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 15, 2018

praveenkumar added a commit to praveenkumar/minishift that referenced this issue Jun 15, 2018

LalatenduMohanty added a commit that referenced this issue Jun 15, 2018

@LalatenduMohanty

This comment has been minimized.

Copy link
Member

LalatenduMohanty commented Jun 15, 2018

Resolved via #2448

@gbraad gbraad changed the title Addon: how to retreive a value from an internal variable ? Addon: how to retrieve a value from an internal variable ? Jun 25, 2018

rhnvrm added a commit to rhnvrm/minishift that referenced this issue Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.