New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement host folder mounts using sshfs #317

Closed
hferentschik opened this Issue Jan 23, 2017 · 11 comments

Comments

@hferentschik
Member

hferentschik commented Jan 23, 2017

To have a consistent hypervisor independent solution for host folder mounts, we could implement a vagrant-sshfs equivalent for Minishift. This would come down to:

  • Prepare our ISOs with sshfs
  • Use Golang's sftp server functionality to create a sftp daemon process on the host
    • As with vagrant-sshfs, the tricky part is to be able to properly spawn daemon processes on on all OS types. For Windows in particular it means we will have to make Win32 API calls.
    • Expose commands within the CLI to start/stop the sftp server
  • Write the glue code which wires up the sftp server on host with sshfs in the VM

@hferentschik hferentschik added this to the v1.0.0-cr.1 milestone Jan 23, 2017

@praveenkumar

This comment has been minimized.

Show comment
Hide comment
@praveenkumar

praveenkumar Jan 23, 2017

Contributor
  • SELinux context should be set accordingly for mounted folders.
Contributor

praveenkumar commented Jan 23, 2017

  • SELinux context should be set accordingly for mounted folders.
@gbraad

This comment has been minimized.

Show comment
Hide comment
@gbraad

gbraad May 17, 2017

Member

docker/machine#4018 (sshfs mount functionality in docker-machine)

Member

gbraad commented May 17, 2017

docker/machine#4018 (sshfs mount functionality in docker-machine)

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.4.0, v1.3.0 Jun 28, 2017

@hferentschik hferentschik removed this from the v1.4.0 milestone Jul 14, 2017

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 4, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 4, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 4, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 4, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 4, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 4, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

Issue #317 Implementing sshfs hostfolder support
- Add hidden sftpd command
- Refactor existing hostfolder actions

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

Issue #317 Refactoring existing hostfolder code
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.14.0, v1.16.0 Mar 5, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 6, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 6, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 6, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 7, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 7, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 7, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 10, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs
@LalatenduMohanty

This comment has been minimized.

Show comment
Hide comment
@LalatenduMohanty

LalatenduMohanty Mar 12, 2018

Member

To track the test results of #2093 , here is a list of combinations we need to test

OS/Platform ISO Hypervisor Owner Result/Comments
Windows 10 CentOS HyperV
Windows 10 B2d HyperV
Windows 10 B2d Virtualbox @budhrg OK
Fedora 26+ CentOS KVM
Fedora 26+ B2d KVM
macOS CentOS Xhyve @LalatenduMohanty swap file issue
macOS B2d Xhyve
macOS CentOS Virtualbox
Member

LalatenduMohanty commented Mar 12, 2018

To track the test results of #2093 , here is a list of combinations we need to test

OS/Platform ISO Hypervisor Owner Result/Comments
Windows 10 CentOS HyperV
Windows 10 B2d HyperV
Windows 10 B2d Virtualbox @budhrg OK
Fedora 26+ CentOS KVM
Fedora 26+ B2d KVM
macOS CentOS Xhyve @LalatenduMohanty swap file issue
macOS B2d Xhyve
macOS CentOS Virtualbox

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 13, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 13, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 14, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

LalatenduMohanty added a commit that referenced this issue Mar 14, 2018

Issue #317 Refactoring existing hostfolder code and implementing sshf…
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.16.0, v1.15.0 Mar 14, 2018

@LalatenduMohanty

This comment has been minimized.

Show comment
Hide comment
@LalatenduMohanty

LalatenduMohanty Mar 14, 2018

Member

Resolved via #2093

Member

LalatenduMohanty commented Mar 14, 2018

Resolved via #2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment