/minishift

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement host folder mounts using sshfs #317

Closed
hferentschik opened this Issue Jan 23, 2017 · 11 comments

Comments

Assignees

@hferentschik hferentschik

Labels
Projects
None yet
Milestone
  v1.15.0
5 participants
@hferentschik @praveenkumar @gbraad @LalatenduMohanty @budhram
@hferentschik
Member

hferentschik commented Jan 23, 2017 •
edited

To have a consistent hypervisor independent solution for host folder mounts, we could implement a vagrant-sshfs equivalent for Minishift. This would come down to:

  • Prepare our ISOs with sshfs
  • Use Golang's sftp server functionality to create a sftp daemon process on the host
    • As with vagrant-sshfs, the tricky part is to be able to properly spawn daemon processes on on all OS types. For Windows in particular it means we will have to make Win32 API calls.
    • Expose commands within the CLI to start/stop the sftp server
  • Write the glue code which wires up the sftp server on host with sshfs in the VM

@hferentschik hferentschik added kind/feature priority/critical labels Jan 23, 2017

@hferentschik hferentschik added this to the v1.0.0-cr.1 milestone Jan 23, 2017

@praveenkumar

This comment has been minimized.

Show comment
Hide comment
@praveenkumar

praveenkumar Jan 23, 2017

Contributor
  • SELinux context should be set accordingly for mounted folders.
Contributor

praveenkumar commented Jan 23, 2017

  • SELinux context should be set accordingly for mounted folders.

@hferentschik hferentschik modified the milestones: v1.0.0-rc.1, v1.0.0-beta.4 Jan 27, 2017

@hferentschik hferentschik referenced this issue Feb 1, 2017

Closed

Investigate host folder mounts via sshfs #358

@hferentschik hferentschik modified the milestones: v1.0.0, v1.0.0-rc.1 Feb 20, 2017

@hferentschik hferentschik modified the milestones: v1.0.0, v1.0.0-rc.1 Mar 14, 2017

@hferentschik hferentschik modified the milestones: v1.0.0, v1.0.0-rc.2 Apr 3, 2017

This was referenced Apr 4, 2017

Closed
Closed

@hferentschik hferentschik removed this from the v1.0.0-rc.2 milestone Apr 5, 2017

@LalatenduMohanty LalatenduMohanty added this to the v1.16.0 milestone Mar 5, 2018

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

@hferentschik
Issue minishift#317 WIP integrate sshfs
Loading status checks…
2c2c55c

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 5, 2018

@hferentschik
Issue minishift#317 WIP integrate sshfs
Loading status checks…
91fe246

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 6, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively
Loading status checks…
847d477

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 6, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively
Loading status checks…
ffffdf7

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 6, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively
- Adding docs
Loading status checks…
d4ae693

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 7, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
3d5d208

@hferentschik hferentschik referenced this issue Mar 7, 2018

Merged

Issue #317 Refactoring existing hostfolder code and implementing sshfs hostfolders #2093

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 7, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
31970dd

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 7, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
b4f947d

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
823c3f0

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
1e69bb7

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
84fa322

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 8, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
8c66dab

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 10, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
1884575
@LalatenduMohanty

This comment has been minimized.

Show comment
Hide comment
@LalatenduMohanty

LalatenduMohanty Mar 12, 2018

Member

To track the test results of #2093 , here is a list of combinations we need to test

OS/Platform ISO Hypervisor Owner Result/Comments
Windows 10 CentOS HyperV
Windows 10 B2d HyperV
Windows 10 B2d Virtualbox @budhrg OK
Fedora 26+ CentOS KVM
Fedora 26+ B2d KVM
macOS CentOS Xhyve @LalatenduMohanty swap file issue
macOS B2d Xhyve
macOS CentOS Virtualbox
Member

LalatenduMohanty commented Mar 12, 2018 •
edited

To track the test results of #2093 , here is a list of combinations we need to test

OS/Platform ISO Hypervisor Owner Result/Comments
Windows 10 CentOS HyperV
Windows 10 B2d HyperV
Windows 10 B2d Virtualbox @budhrg OK
Fedora 26+ CentOS KVM
Fedora 26+ B2d KVM
macOS CentOS Xhyve @LalatenduMohanty swap file issue
macOS B2d Xhyve
macOS CentOS Virtualbox

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
93cd8f4

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
Verified
This commit was signed with a verified signature.
@hferentschik hferentschik Hardy Ferentschik
GPG key ID: 12B1B847A135645D Learn about signing commits
2b8112c

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
Verified
This commit was signed with a verified signature.
@hferentschik hferentschik Hardy Ferentschik
GPG key ID: 12B1B847A135645D Learn about signing commits
14f2e08

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
Verified
This commit was signed with a verified signature.
@hferentschik hferentschik Hardy Ferentschik
GPG key ID: 12B1B847A135645D Learn about signing commits
0acd627

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 12, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
Verified
This commit was signed with a verified signature.
@hferentschik hferentschik Hardy Ferentschik
GPG key ID: 12B1B847A135645D Learn about signing commits
e2b7c38

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 13, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
Verified
This commit was signed with a verified signature.
@hferentschik hferentschik Hardy Ferentschik
GPG key ID: 12B1B847A135645D Learn about signing commits
48d043c

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 13, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
Verified
This commit was signed with a verified signature.
@hferentschik hferentschik Hardy Ferentschik
GPG key ID: 12B1B847A135645D Learn about signing commits
d5340f0

hferentschik added a commit to hferentschik/minishift that referenced this issue Mar 14, 2018

@hferentschik
Issue minishift#317 Refactoring existing hostfolder code and implemen… 
…ting sshfs hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue minishift#959)
- Adding docs
a5d5a4d

LalatenduMohanty added a commit that referenced this issue Mar 14, 2018

@hferentschik @LalatenduMohanty
Issue #317 Refactoring existing hostfolder code and implementing sshf… 
…s hostfolders

- Add hidden sftpd command
- Refactor existing hostfolder actions
- Introducing hostfolder.Manager as entry point for hostfolder operations
- Introducing HostFolder interface as common abstraction for any host folder type
- Split impl details between CIFS and SSHFS
- Allow to configure host folder interactively as well as non-interactively (Issue #959)
- Adding docs
5a93a78

@LalatenduMohanty LalatenduMohanty modified the milestones: v1.16.0, v1.15.0 Mar 14, 2018

@LalatenduMohanty

This comment has been minimized.

Show comment
Hide comment
@LalatenduMohanty

LalatenduMohanty Mar 14, 2018

Member

Resolved via #2093
Member

LalatenduMohanty commented Mar 14, 2018

Resolved via #2093

@LalatenduMohanty LalatenduMohanty closed this Mar 14, 2018

@LalatenduMohanty LalatenduMohanty added the resolution/done label Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment