From f50eab92ac8d576d5d9c99b7657b5332c11beabd Mon Sep 17 00:00:00 2001 From: Niall Creech Date: Fri, 24 Feb 2017 16:52:04 +0000 Subject: [PATCH] Fix ACM alternative name tests ACM needs separate domain validation options for each subject alternative name. This is fixed in another PR, this change updates the checks to reflect this. --- tests/test_acm.py | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/tests/test_acm.py b/tests/test_acm.py index 9a90e92..a2acc06 100755 --- a/tests/test_acm.py +++ b/tests/test_acm.py @@ -37,15 +37,25 @@ def test_acm(self): ] subject_alternative_names = ['goodbye.test.dsd.io', 'hello_again.test.dsd.io'] - domain_validation_options = DomainValidationOption( - DomainName=domain_name, - ValidationDomain=validation_domain - ) + domain_validation_options = [ + DomainValidationOption( + DomainName=domain_name, + ValidationDomain=validation_domain + ), + DomainValidationOption( + DomainName=subject_alternative_names[0], + ValidationDomain=validation_domain + ), + DomainValidationOption( + DomainName=subject_alternative_names[1], + ValidationDomain=validation_domain + ) + ] ACMCertificate = Certificate( certificate_name, DomainName=domain_name, SubjectAlternativeNames=subject_alternative_names, - DomainValidationOptions=[domain_validation_options], + DomainValidationOptions=domain_validation_options, Tags=tags ) certificate_cfg = [config_parser._get_acm_certificate(certificate_name)]