fixing broken tests

ministryofjustice · May 15, 2014 · d6385f0 · d6385f0
1 parent 0713467
commit d6385f0
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/Opg/Core/Model/Entity/CaseItem/CaseItem.php b/src/Opg/Core/Model/Entity/CaseItem/CaseItem.php
@@ -737,8 +737,10 @@ public function getRagRating()
             '3' => 0
         );
 
-        foreach ($this->tasks as $taskItem) {
-            $rag[$taskItem->getRagRating()]++;
+        if(!empty($tasks)) {
+            foreach ($this->tasks as $taskItem) {
+                $rag[$taskItem->getRagRating()]++;
+            }
         }
 
         //Apply rules
@@ -756,10 +758,12 @@ public function getRagRating()
      */
     public function getRagTotal()
     {
-       $total = 0;
+        $total = 0;
 
-        foreach ($this->tasks as $taskItem) {
-            $total += $taskItem->getRagRating();
+        if(!empty($tasks)) {
+            foreach ($this->tasks as $taskItem) {
+                $total += $taskItem->getRagRating();
+            }
         }
 
         return $total;