New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7 and add some more functions. #12

Merged
merged 7 commits into from Jun 21, 2015

Conversation

Projects
None yet
2 participants
@wkoszek
Copy link
Contributor

wkoszek commented Jun 20, 2015

No description provided.

wkoszek added some commits Jun 6, 2015

Be consistent with Spellchecker class and call language "lang", not d…
…ictionary.

Also don't pass the default "lang", as it should only be done in the highest
levels.
Bring an ability for middleman-spellcheck to use its own custom command
line invocation. This is useful if you know what you're doing. Otherwise
you'll likely cause middleman to hang at "middleman build"

You must have at least -a flag specified.
Fix issue 7 by re-doing data passing to aspell.
For long paragraphs passing data via the command-line arguments doesn't
work. Instead we create a pipe and send data to aspell.

We send them word by word, since the other approach was hard to debug.

I add quite a bit of debugging which since I suspect guys using
middleman-spellcheck for other languages will probably hit some more
issues. Debugging can be enabled from middleman's config.rb via

	activate :spellcheck, debug:1

Fixes #7

minivan added a commit that referenced this pull request Jun 21, 2015

Merge pull request #12 from wkoszek/master
Fixes #7 and add some more functions.

@minivan minivan merged commit 994b834 into minivan:master Jun 21, 2015

@minivan

This comment has been minimized.

Copy link
Owner

minivan commented Jun 21, 2015

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment