Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Mink dependency in composer.json to 1.6x #93

Merged
merged 1 commit into from May 15, 2014

Conversation

aik099
Copy link
Member

@aik099 aik099 commented May 15, 2014

Related to Behat/Mink#548

@stof
Copy link
Member

stof commented May 15, 2014

We don't depend on 1.6 changes yet here AFAIK. So it is not strictly needed in fact

@aik099
Copy link
Member Author

aik099 commented May 15, 2014

Is there a universal way to know if a driver depends on 1.6 or not?

@stof
Copy link
Member

stof commented May 15, 2014

@aik099 actually, given that all drivers have their testsuite updated to the new structure, they actually depend on Mink 1.6 at least to run their tests

@aik099
Copy link
Member Author

aik099 commented May 15, 2014

Yes, I thought that too. So what should we do, merge these PR's?

@stof
Copy link
Member

stof commented May 15, 2014

yeah, go ahead and merge them.

And regarding the Mink 1.6 release, I suggest that we release it at the end of the weekend (with as many new form tests in it than possible to ensure that setValue and selectOption work). Then, the 1.2 version of drivers (or whatever their next version is, but it is 1.2 for most of them) will be released as soon as they pass the testsuite. I think that we will be able to have BrowserKit and Goutte ready at this time (they will pass these form tests as the logic is already handled properly in Symfony AFAIK), and hopefully Selenium2 and Zombie (marking the duplicate change event as skipped, or better as incomplete, until the Zombie issue is fixed to be able to have other tests reporting a useful status). Sahi and Selenium1 will not be ready for the release at this time, but they can be released a bit later (this is what is great with separate repos too).
does this plan look good to you ?

aik099 pushed a commit that referenced this pull request May 15, 2014
Updating Mink dependency in `composer.json` to 1.6x
@aik099 aik099 merged commit 173908b into master May 15, 2014
@aik099 aik099 deleted the update-mink-dependency-to-1.6x branch May 15, 2014 15:03
@aik099
Copy link
Member Author

aik099 commented May 15, 2014

yeah, go ahead and merge them.

Done.

... And regarding the Mink 1.6 release, I suggest that we release it at the end of the weekend (with as many ...

Release plan looks good. Main thing is to release Mink with tests covering every aspect of a driver.

But currently we still miss some tests:

@stof
Copy link
Member

stof commented May 15, 2014

to be exact, the list of issues I would like to solve for 1.6 (for driver-related issues, solving meaning adding tests in the driver testsuite to enforce the behavior) is now available with the 1.6 milestone: https://github.com/Behat/Mink/issues?direction=desc&labels=&milestone=1&page=1&sort=created&state=open
I added the relevant issues in it.

@aik099
Copy link
Member Author

aik099 commented May 15, 2014

Great, looks good. I hope it won't grow rapidly and prevent releasing in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants