New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Mink dependency in composer.json
to 1.6x
#93
Conversation
We don't depend on 1.6 changes yet here AFAIK. So it is not strictly needed in fact |
Is there a universal way to know if a driver depends on 1.6 or not? |
@aik099 actually, given that all drivers have their testsuite updated to the new structure, they actually depend on Mink 1.6 at least to run their tests |
Yes, I thought that too. So what should we do, merge these PR's? |
yeah, go ahead and merge them. And regarding the Mink 1.6 release, I suggest that we release it at the end of the weekend (with as many new form tests in it than possible to ensure that |
Updating Mink dependency in `composer.json` to 1.6x
Done.
Release plan looks good. Main thing is to release Mink with tests covering every aspect of a driver. But currently we still miss some tests: |
to be exact, the list of issues I would like to solve for 1.6 (for driver-related issues, solving meaning adding tests in the driver testsuite to enforce the behavior) is now available with the 1.6 milestone: https://github.com/Behat/Mink/issues?direction=desc&labels=&milestone=1&page=1&sort=created&state=open |
Great, looks good. I hope it won't grow rapidly and prevent releasing in time. |
Related to Behat/Mink#548