Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code of conduct agreement #235

Merged

Conversation

aackerman
Copy link
Contributor

Fixes #218

@coveralls
Copy link

coveralls commented Jul 17, 2019

Coverage Status

Coverage increased (+0.5%) to 61.683% when pulling 944e175 on aackerman:aackerman/code-of-conduct-agreement into d58ece5 on minnestar:master.

@aackerman aackerman marked this pull request as ready for review July 21, 2019 20:41
@aackerman aackerman requested a review from jcoyne October 13, 2019 17:51
@jennapederson
Copy link
Member

Hey @aackerman - What's the scoop on some of these Travis failures? Wondering if the setup is still in progress or if we're good to merge some of these even with it failing.

@aackerman
Copy link
Contributor Author

@jennapederson at some point the default build image on travis changed from ubuntu trusty to ubuntu xenial and the CI setup stopped working, looks like about 5 months ago. I've added configuration to run on ubuntu trusty.

@jennapederson
Copy link
Member

@aackerman I want to make sure I understand how this will work in real life... a person creates a session and goes to add another presenter to the session. they won't be able to until that person has agreed to the coc, right? and each coc agreement is for an event, right?

what happens if we push this to production after some sessions/presenters have already been created/added? they'll be ok, but any new sessions/presenters added will have to agree?

I think that's ok, but want to be able to message Maria and others who get to field questions in case something comes up!

Thank you for working on this!

@aackerman
Copy link
Contributor Author

@jennapederson it's been a few months but yes that's how I expect it to work, new sessions and new participants will have to agree.

@jennapederson
Copy link
Member

@aackerman Same for this -- can you fix conflicts and then we'll get it merged? Thanks!

@jennapederson jennapederson merged commit 4322a68 into minnestar:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checkbox to new session form for CoC agreement
4 participants