From 2e1e06003585f0422c1964e116f4059323951701 Mon Sep 17 00:00:00 2001 From: Marcos Minond Date: Thu, 30 Jan 2014 23:10:25 -0700 Subject: [PATCH] code review fixes --- composer.json | 1 + src/Efficio/Http/Error/DuplicateRuleException.php | 1 - src/Efficio/Http/Rule.php | 2 -- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 402bf31..a2bc801 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,7 @@ { "name": "minond/http", "description": "Http helpers", + "license": "GPL-2.0+", "authors": [ { diff --git a/src/Efficio/Http/Error/DuplicateRuleException.php b/src/Efficio/Http/Error/DuplicateRuleException.php index cbd5bad..05b3875 100644 --- a/src/Efficio/Http/Error/DuplicateRuleException.php +++ b/src/Efficio/Http/Error/DuplicateRuleException.php @@ -7,7 +7,6 @@ /** * duplicate rule exception - * @used-by RuleBook */ class DuplicateRuleException extends Exception { diff --git a/src/Efficio/Http/Rule.php b/src/Efficio/Http/Rule.php index 63eac81..f441d4e 100644 --- a/src/Efficio/Http/Rule.php +++ b/src/Efficio/Http/Rule.php @@ -129,9 +129,7 @@ public function matches($req) { $match = false; $matches = []; - $exp = ''; $uri = $req; - $method = false; $runcheck = true; if ($req instanceof Request) {