From 20002b1b2fbfcbf93224b358ea84a6fea13788e2 Mon Sep 17 00:00:00 2001 From: Vladyslav Fenchak Date: Wed, 16 Feb 2022 17:24:26 +0100 Subject: [PATCH 1/3] ISSUE #195 --- .../minos/aggregate/events/models.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py b/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py index 9da950cdb..e35a3f1f4 100644 --- a/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py +++ b/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py @@ -76,6 +76,10 @@ def __getattr__(self, item: str) -> Any: raise exc def get_one(self, name: str, return_diff: bool = False) -> Union[FieldDiff, Any, list[FieldDiff], list[Any]]: + warnings.warn("get_one() method is deprecated by get_attr() and will be removed soon.", DeprecationWarning) + return self.get_attr(name, return_diff) + + def get_attr(self, name: str, return_diff: bool = False) -> Union[FieldDiff, Any, list[FieldDiff], list[Any]]: """Get first field diff with given name. :param name: The name of the field diff. @@ -86,6 +90,10 @@ def get_one(self, name: str, return_diff: bool = False) -> Union[FieldDiff, Any, return self.fields_diff.get_one(name, return_diff) def get_all(self, return_diff: bool = False) -> dict[str, Union[FieldDiff, Any, list[FieldDiff], list[Any]]]: + warnings.warn("get_all() method is deprecated by get_attrs() and will be removed soon.", DeprecationWarning) + return self.get_attrs(return_diff) + + def get_attrs(self, return_diff: bool = False) -> dict[str, Union[FieldDiff, Any, list[FieldDiff], list[Any]]]: """Get all field diffs with given name. :param return_diff: If ``True`` the result is returned as field diff instances, otherwise the result is From d3cb918beec52d4622300ba7cf2dfe3dcbefb460 Mon Sep 17 00:00:00 2001 From: Vladyslav Fenchak Date: Wed, 16 Feb 2022 17:30:55 +0100 Subject: [PATCH 2/3] ISSUE #195 --- .../minos/aggregate/events/models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py b/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py index e35a3f1f4..0019002dc 100644 --- a/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py +++ b/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py @@ -1,7 +1,7 @@ from __future__ import ( annotations, ) - +import warnings import logging from datetime import ( datetime, From b77ca177324d23aa7c85c1342f7cd8e56eb487ff Mon Sep 17 00:00:00 2001 From: "Restyled.io" Date: Wed, 16 Feb 2022 16:31:05 +0000 Subject: [PATCH 3/3] Restyled by isort --- .../minos/aggregate/events/models.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py b/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py index 0019002dc..20fc074a4 100644 --- a/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py +++ b/packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py @@ -1,8 +1,9 @@ from __future__ import ( annotations, ) -import warnings + import logging +import warnings from datetime import ( datetime, )