Permalink
Browse files

use system_raw in terminal, even on Windows

`system_raw` uses `os.system` instead of `utils.process.system`, and makes
more sense in a Terminal session.

There was discussion that it should be otherwise on Windows, but I can't
find any actual evidence for why this would be the case, and there are very
clear disadvantages to not using `os.system` (see #978 and #181).

closes gh-978
  • Loading branch information...
1 parent 7c0ffa5 commit a7b48096fb72d83d64a6c0cc556ce39d1897c2c1 @minrk committed Nov 9, 2011
Showing with 3 additions and 5 deletions.
  1. +3 −5 IPython/frontend/terminal/interactiveshell.py
@@ -112,11 +112,9 @@ def __init__(self, config=None, ipython_dir=None, profile_dir=None, user_ns=None
config=config, profile_dir=profile_dir, user_ns=user_ns,
user_global_ns=user_global_ns, custom_exceptions=custom_exceptions
)
- # use os.system instead of utils.process.system by default, except on Windows
- if os.name == 'nt':
- self.system = self.system_piped
- else:
- self.system = self.system_raw
+ # use os.system instead of utils.process.system by default,
+ # because piped system doesn't make sense in the Terminal:
+ self.system = self.system_raw
self.init_term_title()
self.init_usage(usage)

0 comments on commit a7b4809

Please sign in to comment.