Skip to content

Conversation

@mintlify-development
Copy link
Contributor

@mintlify-development mintlify-development bot commented Jun 21, 2024

Copy link
Member

@hahnbeelee hahnbeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so it looks like there are several different types of information we are surfacing to the user:

  1. educating them about the feature at a high level
  2. which option should they use?
  3. how to implement each option
  4. API reference/shape of the user auth object
  5. After wiring everything up properly - then actually customizing the data.

Things feel kinda jumbled up right now and there is a lot we are trying to accomplish.

I personally really like separating the pure technical content and more walking through/explaining the feature content - For the jwt and shared session pages, maybe we can create separate pages purely for setting up instructions and then just one page that guides you through which one you should be using (AKA all the pro's and con's and examples) which the overview page should then have links to all of these.

1. **Private docs content.** While you can hide pages from unauthenticated users, those pages are still accessible by anyone who can guess the URL. If your documentation contains sensitive information, User Auth is not enough to hide it.
2. **A Mintlify-backed user database.** Mintlify does not store *any* information about your users. Rather, it relies on your existing infrastructure to serve as the source-of-truth for user data.

## How to Use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should have a "How to Set Up" or at least like right below this "How to Use" explain that you need to choose between shared session or jwt and set it up in the dashboard?

@hahnbeelee
Copy link
Member

I also think we could be doing more to really help the user understand what they can be accomplishing with this feature but I do think overall the overview page is really well written and i dont have tangible feedback on how to accomplish this.

@rpmccarter rpmccarter requested a review from hahnbeelee June 25, 2024 02:43
</Step>
</Steps>

## Examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the examples should also go in the "choosing" page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it makes sense to have the examples here for when people actually need to implement stuff, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@rpmccarter rpmccarter merged commit 93a3572 into main Jun 25, 2024
@rpmccarter rpmccarter deleted the ronan/eng-2847-create-docs-for-user-auth branch June 25, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants