Use channels to pass data to the debug tui #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
Signed-off-by: Evan Harris <echarris@smcm.edu>
kcq
reviewed
Oct 28, 2024
| func (ref *Output) Data(channelKey string, data interface{}) { | ||
| if ch, exists := ref.DataChannels[channelKey]; exists { | ||
| ch <- data // Send data to the corresponding channel | ||
| fmt.Printf("Data sent to channel '%s': %v\n", channelKey, data) |
Contributor
There was a problem hiding this comment.
let's use logrus log instead of fmt.Printf
Contributor
Author
There was a problem hiding this comment.
Noted. Will update / remove.
kcq
reviewed
Oct 28, 2024
| ch <- data // Send data to the corresponding channel | ||
| fmt.Printf("Data sent to channel '%s': %v\n", channelKey, data) | ||
| } else { | ||
| fmt.Printf("Channel for channelKey '%s' not found\n", channelKey) |
Contributor
There was a problem hiding this comment.
let's use logrus log instead of fmt.Printf
Contributor
Author
There was a problem hiding this comment.
Noted. Will update / remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
debugtui via an internal channel on execution context.Infoto a provideddataChannelvia aninternalDataCh[note - channel naming should be consistent]OutputFormatfor execution context is specified as"subscription"- then the channels are used to pipe data. This is only implemented for.Infoat the moment for this Proof of Concept.Why
Questions
debug --tuieffectively drops all other provided flags on the floor. This could be a poor UX.--tuiflag as a standalone flag, then perform interactions inside of the interface?debug --tui --runtime=k8s --target=my-nginxbe a desired entrypoint to support? DevX wise - for ease of using the last invoked command without writing out things by hand in a TUI, supporting flags alongside --tui feels relevant.How Tested
mint debug --tuimint images --tuimint tui->d